Skip to content

Conversation

@artur-ciocanu
Copy link
Contributor

Description

This is a tiny PR to expose connection details so it can be used in other contexts, like #1230.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
@artur-ciocanu artur-ciocanu requested review from a team as code owners May 12, 2025 16:45
@artur-ciocanu
Copy link
Contributor Author

@salaboy and @cicoyle could you please review, this is related to Spring Cloud Config PR #1230.

@salaboy
Copy link
Collaborator

salaboy commented May 12, 2025

LTGM it is ready to merge

Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artur-ciocanu artur-ciocanu mentioned this pull request May 12, 2025
3 tasks
@artur-ciocanu
Copy link
Contributor Author

@salaboy I need an approval to merge.

@cicoyle cicoyle merged commit 4e1fbbe into dapr:master May 13, 2025
11 of 12 checks passed
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.28%. Comparing base (d759c53) to head (60e1dc3).
Report is 141 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1341      +/-   ##
============================================
+ Coverage     76.91%   77.28%   +0.36%     
- Complexity     1592     1765     +173     
============================================
  Files           145      204      +59     
  Lines          4843     5388     +545     
  Branches        562      590      +28     
============================================
+ Hits           3725     4164     +439     
- Misses          821      908      +87     
- Partials        297      316      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@artur-ciocanu artur-ciocanu deleted the fix-connection-details branch May 13, 2025 16:37
@cicoyle cicoyle added this to the v1.16 milestone Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants