Fix bug in continue_as_new [deprecated] #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on the complete action. Linting - Normalize strings to use double-quotes consistently across tests and source files as used in msft durabletask. - Run ruff format - Add `test_continue_as_new_with_activity_e2e` for better coverage of `continue_as_new` functionality. - Modify `.flake8` for extended exclusions and per-file ignores. - Introduce `tox.ini` for test environment configurations and streamline linting, typing, and example validation. Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
filintod
changed the title
filintod
commented
Oct 10, 2025
Author
|
@acroca ptal |
acroca
reviewed
Oct 10, 2025
Co-authored-by: Albert Callarisa <albert@acroca.com> Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
filintod
commented
Oct 10, 2025
filintod
commented
Oct 10, 2025
…s.txt` and update related files and workflows. Dump flake8 and use ruff that covers format and linting. Update readme Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
Author
|
@acroca ptal. I dump flake8, and took your feedback points |
acroca
approved these changes
Oct 10, 2025
Collaborator
|
@filintod can you pls update from main? |
Author
|
I open this one #24, that is a subset of this PR. but this PR can serve for inspiration for the linting or modifying pyproject/tox/fluke that was done here |
filintod
changed the title
Author
|
closing as new lint PR is about to be merged with most of the functionality here in place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflows with continue as new would fail after the continue_as_new statement as it was missing router information
Linting
test_continue_as_new_with_activity_e2efor better coverage ofcontinue_as_newfunctionality..flake8for extended exclusions and per-file ignores.tox.inifor test environment configurations and streamline linting, typing, and example validation.