Skip to content

Conversation

Copy link

Copilot AI commented Dec 9, 2025

The rows per page dropdown selector was non-functional - selecting 20, 50, or 100 had no effect, always displaying 10 rows.

Changes

  • Fixed onPageSizeChange handler in KeystoresDataGrid.tsx to accept and use the new page size value
// Before: callback ignores the new page size parameter
onPageSizeChange={() => setPageSize(pageSize)}

// After: callback properly updates state with new value
onPageSizeChange={(newPageSize) => setPageSize(newPageSize)}

The handler was setting page size to its current value instead of the selected dropdown value.

Original prompt

This section details on the original issue you should resolve

<issue_title>Rows Per Page dropdown selector does not work in the Staking Brain UI</issue_title>
<issue_description>Describe the bug

In the Staking Brain UI, there is a small dropdown in the lower right corner.

The label says:
Rows per page:

It is followed by a drop down menu with the options 10, 20, 50, 100
The default selection is 10

Changing the menu to any other number does not affect the page layout. It always shows 10 lines.

Expected behavior

It should show more lines when you select 20, 50, or 100

Screenshots

DAppNode version:

Core DAppNode Packages versions

bind.dnp.dappnode.eth: 0.2.11
core.dnp.dappnode.eth: 0.2.96
dappmanager.dnp.dappnode.eth: 0.2.90, commit: df351d59
https.dnp.dappnode.eth: 0.2.2
ipfs.dnp.dappnode.eth: 0.2.23
wifi.dnp.dappnode.eth: 0.2.9
wireguard.dnp.dappnode.eth: 0.1.3

System info

dockerComposeVersion: 2.29.1
dockerServerVersion: 27.1.2
dockerCliVersion: 27.1.2
os: debian
versionCodename: bookworm
architecture: amd64
kernel: 6.1.0-22-amd64
Disk usage: 40%

Additional context
Ideally the in-page scrollbar should also be removed.
There is no good reason to have just a small number of lines visible on the page.

Use the whole page, and let the user scroll the whole page if the number of lines is large.

The only caveat is whether you need a permanent page header that includes the small links for link, edit, delete, exit that are currently shown just above the scrolling list.
</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Dec 9, 2025
Co-authored-by: pablomendezroyo <41727368+pablomendezroyo@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix rows per page dropdown selector in Staking Brain UI Fix rows per page dropdown in validator list table Dec 9, 2025
Copilot AI requested a review from pablomendezroyo December 9, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rows Per Page dropdown selector does not work in the Staking Brain UI

2 participants