add globalenvs needed by staker-metrics #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3alpha
approved these changes
Apr 16, 2025
pablomendezroyo
requested changes
Apr 21, 2025
| }, | ||
| "globalEnvs": [ | ||
| { | ||
| "envs": [ |
Contributor
There was a problem hiding this comment.
The preffix _DAPPNODE_GLOBAL is required. Also, we should consider changing the way we retrieve the clients selected in dappnode from global envs to use the fullnode alias and getting the client from the API. i.e beacon client can be obtained from API endpoint https://ethereum.github.io/beacon-APIs/#/Node/getNodeVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.