[Draft] Proposition of a different packaging for this project #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Following up my first PR (dcdpr/http-link-header-cpp#3) for http-link-header-cpp, here is a draft of my changes to make the package easier to pull in a package manager (specifically conan in this case).
I noticed that we are not using some dependencies:
cpr/1.10.0: it is never used.http-link-header-cpp/0.9.0: it is never used, but we use through it the transitive dependencyuriparser.Why are we pulling those dependencies if we don't use it ? Is there any plan to use them in the future ?
I am interested in your feedbacks. I hope this PR, associated to dcdpr/http-link-header-cpp#3, will help for an overall vision of the proposed changes.
Regards,
Matthieu