Replace ArrayPool with direct allocation and improve line terminator handling #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ArrayPool<char>with directchar[]allocation when appending newlines inGrammar.Tokenize().ArrayPoolbuffers can be reused with different content, which breaks Onigwrap's regex search caching (uses memory reference equality). Direct allocation creates unique buffers that enable proper caching, improving overall tokenization performance.ReadOnlyMemory<char>slices from a single file read. This avoids per-line allocations and demonstrates the optimal usage pattern.ITMModelinterfaces, including guidance thatGetLineText()should return lines with terminators to avoid internal allocations.IModelLines.GetLineText()was renamed toIModelLines.GetLineTextIncludingTerminators()for API clarity.