-
Notifications
You must be signed in to change notification settings - Fork 15
Update test configuration to vendorize dandiapi instance used in tests #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #355 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 18 18
Lines 2377 2377
=======================================
Hits 2327 2327
Misses 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f891a26 to
bc2506d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the GitHub Actions test workflow to support vendorized dandiapi instances in tests. It adds matrix configuration for testing against the ember-dandi instance with specific instance metadata (name, identifier, DOI prefix).
Key changes:
- Adds
vendored_dandiapimatrix dimension with "default" option - Introduces two new test matrix combinations for ember-dandi with both master and release versions
- Conditionally sets environment variables for instance configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
bc2506d to
b95e6df
Compare
b95e6df to
4d20337
Compare
|
@candleindark note that we got conflicts now |
|
@yarikoptic I accidentally deleted the wrong branch because I mixed this branch with the one I created for dandi/dandi-cli#1771. I will create another PR. |
|
there is "Restore branch" button I see which I guess could have just been pressed? |
I don't see that button. I deleted the branch as a remote branch via terminal. |
|
testing |
This PR updates test configuration in a GH workflow to vendorize the dandiapi instance used in tests. It builds on dandi/dandi-cli#1756, so it only works property after dandi/dandi-cli#1756 is merged.
This PR closes #350.
Notes: