Skip to content

Conversation

@candleindark
Copy link
Member

@candleindark candleindark commented Nov 25, 2025

This PR updates test configuration in a GH workflow to vendorize the dandiapi instance used in tests. It builds on dandi/dandi-cli#1756, so it only works property after dandi/dandi-cli#1756 is merged.

This PR closes #350.

Notes:

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.89%. Comparing base (58ccbca) to head (18fae25).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          18       18           
  Lines        2377     2377           
=======================================
  Hits         2327     2327           
  Misses         50       50           
Flag Coverage Δ
unittests 97.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions test workflow to support vendorized dandiapi instances in tests. It adds matrix configuration for testing against the ember-dandi instance with specific instance metadata (name, identifier, DOI prefix).

Key changes:

  • Adds vendored_dandiapi matrix dimension with "default" option
  • Introduces two new test matrix combinations for ember-dandi with both master and release versions
  • Conditionally sets environment variables for instance configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@candleindark candleindark force-pushed the test-against-vendored-dandiapi branch from bc2506d to b95e6df Compare November 26, 2025 02:25
@candleindark candleindark force-pushed the test-against-vendored-dandiapi branch from b95e6df to 4d20337 Compare November 26, 2025 21:35
@yarikoptic yarikoptic added the tests Add or improve existing tests label Dec 4, 2025
@yarikoptic
Copy link
Member

@candleindark note that we got conflicts now

@candleindark candleindark deleted the test-against-vendored-dandiapi branch December 15, 2025 21:27
@candleindark
Copy link
Member Author

@yarikoptic I accidentally deleted the wrong branch because I mixed this branch with the one I created for dandi/dandi-cli#1771.

I will create another PR.

@yarikoptic
Copy link
Member

there is "Restore branch" button I see which I guess could have just been pressed?

@candleindark
Copy link
Member Author

there is "Restore branch" button I see which I guess could have just been pressed?

I don't see that button. I deleted the branch as a remote branch via terminal.

@candleindark
Copy link
Member Author

testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Add or improve existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add vendorized run testing into dandi-cli tests

3 participants