Skip to content

Conversation

@NEStock
Copy link
Contributor

@NEStock NEStock commented Dec 31, 2025

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.07%. Comparing base (6f28a1c) to head (6477182).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1774      +/-   ##
==========================================
- Coverage   75.08%   75.07%   -0.01%     
==========================================
  Files          84       84              
  Lines       11910    11910              
==========================================
- Hits         8943     8942       -1     
- Misses       2967     2968       +1     
Flag Coverage Δ
unittests 75.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic yarikoptic added the internal Changes only affect the internal API label Jan 2, 2026
@yarikoptic
Copy link
Member

we would need to look what's up with the effects on tests

FAILED dandi/tests/test_dandiarchive.py::test_parse_api_url[EMBER-DANDI-SANDBOX:000029/draft-parsed_url14] - AssertionError: assert DandisetURL(i...on_id='draft') == DandisetURL(i...on_id='draft')
  
  Omitting 2 identical items, use -vv to show
  Differing attributes:
  ['instance']
  
  Drill down into differing attribute instance:
    instance: DandiInstance(name='ember-dandi-sandbox', gui='https://apl-setup--ember-dandi-archive.netlify.app', api='https://api-dandi.sandbox.emberarchive.org/api') != DandiInstance(name='ember-dandi-sandbox', gui='https://apl-setup--ember-dandi-archive.netlify.app/', api='https://api-dandi.sandbox.emberarchive.org/api')
    
    Omitting 2 identical items, use -vv to show
    Differing attributes:
    ['gui']
    
    Drill down into differing attribute gui:
      gui: 'https://apl-setup--ember-dandi-archive.netlify.app' != 'https://apl-setup--ember-dandi-archive.netlify.app/'
      - https://apl-setup--ember-dandi-archive.netlify.app/
      ?                                                   -
      + https://apl-setup--ember-dandi-archive.netlify.app
= 1 failed, 903 passed, 1 skipped, 6 deselected, 3 xfailed, 2 xpassed in 680.99s (0:11:20) =

seems like just a trailing / difference, unclear how change of depth in domain name effects that here....

@NEStock
Copy link
Contributor Author

NEStock commented Jan 5, 2026

we would need to look what's up with the effects on tests
@yarikoptic interesting! I wonder if it makes sense to just drop the trailing slash on https://apl-setup--ember-dandi-archive.netlify.app/ ? it looks like it's the only gui value that has a trailing slash

@NEStock
Copy link
Contributor Author

NEStock commented Jan 7, 2026

@yarikoptic I believe the test was fixed by removing the trailing slash. let me know if anything else is required to get this merged. thanks!

@yarikoptic yarikoptic merged commit 3173812 into dandi:master Jan 8, 2026
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Changes only affect the internal API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants