Skip to content

Fix elided fallback name #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hoolean merged 7 commits into from
May 27, 2025
Merged

Fix elided fallback name #52

Hoolean merged 7 commits into from
May 27, 2025

Conversation

@belluzj
Copy link
Contributor

@belluzj belluzj commented Apr 24, 2025 •
edited by Hoolean
Loading

Implements #50

Elided fallback names:

  • Allow a NameRecord to be provided (e.g. a string or localised string) in place of an integer name ID
  • Error if an integer name ID is provided but does not exist in the font
  • Document the field in the example stylespace
  • Add tests for the new and existing behaviour

Other:

  • Document uv + tox setup
  • Remove unused imports

@Hoolean Hoolean force-pushed the fix-elided-fallback-name branch 3 times, most recently from 7e4a761 to 6e9cbe1 Compare April 25, 2025 10:23
@Hoolean Hoolean force-pushed the fix-elided-fallback-name branch from 6e9cbe1 to e6ac246 Compare April 25, 2025 10:55
@Hoolean Hoolean marked this pull request as ready for review April 25, 2025 10:58
madig
madig reviewed Apr 25, 2025
View reviewed changes
belluzj and others added 4 commits May 26, 2025 16:28
@belluzj @Hoolean
Test invalid and NameRecord elided fallbacks, and existing behaviour
0f0a4f2 
Co-authored-by: Harry Dalton <harry.dalton@daltonmaag.com>
@Hoolean
Remove unused imports
39a9dad
@Hoolean
Document elided fallback name ID in example stylespace
d8d396d
@Hoolean
Ensure that the name is explicitly a dict, as fonttools requires this
ee42ae1 
See fonttools/fonttools#3812 - the internal implementation of the name-
-adding function does a type check against dict, and so this type is
explicitly required by the builder function argument.
@Hoolean Hoolean force-pushed the fix-elided-fallback-name branch from 904bd87 to ee42ae1 Compare May 26, 2025 15:28
@Hoolean Hoolean merged commit ff5ab94 into master May 27, 2025
5 checks passed
@Hoolean Hoolean deleted the fix-elided-fallback-name branch May 27, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hoolean Hoolean Hoolean left review comments

@madig madig madig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@belluzj @madig @Hoolean