Week3 3 #5
Open
Week3 3 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousifS
reviewed
Oct 30, 2018
| { | ||
| for (int j = 0; j < board.GetLength(0) - 1; j++) | ||
| { | ||
| if (board[i][j] != board[i][j + 1]) |
There was a problem hiding this comment.
What if the cells of the first row are equal to each other, and they are blank? is that a win?
yousifS
reviewed
Oct 30, 2018
| public static bool DiagonalWin() | ||
| { | ||
| // your code goes here | ||
| if (board[0][2] != board[1][1]) return false; |
There was a problem hiding this comment.
This logic is not correct. what if board[0][2] and board[1][1] are not equal.
But board[0][0], board[1][1] and board[2][2] are equal?
yousifS
reviewed
Oct 30, 2018
| public static bool CheckForTie() | ||
| { | ||
| // your code goes here | ||
|
|
Owner
Author
|
Hi Yousif,
It’s looks like this was the version before we working on it last night. I will push the updated version tonight when I get home.
Sorry for the confusion.
…Sent from my iPhone
On Oct 30, 2018, at 12:53 AM, yousifS ***@***.***> wrote:
@yousifS commented on this pull request.
In TicTacToe/TicTacToe.cs:
> }
+
public static bool CheckForTie()
{
// your code goes here
checkForTie code is missing
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.