Skip to content

Adding support for band.invert() #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bognikol wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding support for band.invert() #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/band.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,20 @@ export default function band() {
return ordinalRange(reverse ? values.reverse() : values);
}

scale.invert = function(_) {
var domainIndex,
n = domain().length,
reverse = range[1] < range[0],
start = range[reverse - 0],
stop = range[1 - reverse];

if (_ < start + paddingOuter * step) domainIndex = 0;
else if (_ > stop - paddingOuter * step) domainIndex = n - 1;
else domainIndex = Math.floor((_ - start - paddingOuter * step) / step);

return domain()[domainIndex];
}

scale.domain = function(_) {
return arguments.length ? (domain(_), rescale()) : domain();
};
Expand Down
23 changes: 23 additions & 0 deletions test/band-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,29 @@ tape("band.range(values) can be descending", function(test) {
test.end();
});

tape("band.invert() return correct domain values", function(test) {
var s = scale.scaleBand().domain(["a", "b", "c"]).range([20, 140]);
test.equal(s.invert(-10), "a");
test.equal(s.invert(20), "a");
test.equal(s.invert(32), "a");
test.equal(s.invert(74), "b");
test.equal(s.invert(128), "c");
test.equal(s.invert(150), "c");
s.paddingInner(0.2);
s.paddingOuter(0.2);
test.equal(s.invert(-10), "a");
test.equal(s.invert(0), "a");
test.equal(s.invert(12), "a");
test.equal(s.invert(20), "a");
test.equal(s.invert(55), "a");
test.equal(s.invert(75), "b");
test.equal(s.invert(100), "b");
test.equal(s.invert(110), "c");
test.equal(s.invert(135), "c");
test.equal(s.invert(150), "c");
test.end();
});

tape("band.range(values) makes a copy of the specified range values", function(test) {
var range = [1, 2],
s = scale.scaleBand().range(range);
Expand Down