Skip to content

Conversation

@SteffenDE
Copy link

@SteffenDE SteffenDE commented Dec 2, 2025

Adds a test for #27311

Closes #26206.

Closes phoenixframework/phoenix_live_view#4071.


Note

Fixes removeAttribute patch so non-target attributes can be removed; adds e2e test and fixture verifying behavior.

  • Driver:
    • Adjust handleInvalidTarget in packages/driver/src/cy/top_attr_guards.ts so patched el.removeAttribute updates internal state only for "target" and always delegates to native removeAttribute.
  • Tests:
    • Add e2e spec packages/driver/cypress/e2e/issues/26206.cy.js and fixture packages/driver/cypress/fixtures/issue-26206.html to verify removing a non-target attribute works after clicking an anchor with target="_top".

Written by Cursor Bugbot for commit a011ae5. This will update automatically on new commits. Configure here.

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2025

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteffenDE Thanks! Can you fix the linting error?

/root/cypress/packages/driver/src/cy/top_attr_guards.ts
  78:5  error  Expected blank line before this statement  padding-line-between-statements

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

phx-change sends stale params after phx-submit when running inside Cypress browser handleInvalidTarget breaks the removeAttribute function

5 participants