fix: handleInvalidTarget breaks the removeAttribute function (#26206) #33051
+35
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for #27311
Closes #26206.
Closes phoenixframework/phoenix_live_view#4071.
Note
Fixes
removeAttributepatch so non-targetattributes can be removed; adds e2e test and fixture verifying behavior.handleInvalidTargetinpackages/driver/src/cy/top_attr_guards.tsso patchedel.removeAttributeupdates internal state only for"target"and always delegates to nativeremoveAttribute.packages/driver/cypress/e2e/issues/26206.cy.jsand fixturepackages/driver/cypress/fixtures/issue-26206.htmlto verify removing a non-targetattribute works after clicking an anchor withtarget="_top".Written by Cursor Bugbot for commit a011ae5. This will update automatically on new commits. Configure here.