-
Notifications
You must be signed in to change notification settings - Fork 107
Refactor eleventy proposal #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit e53c65e.
* Allow the use of Toml formats. * Add _Global Data Files_ as examples. * Use nunjucks for templates. * Move legacy files into separate folder. * Tweak eleventy.config.js. * Based on _Global Data Files_ participants, use `eleventyComputed` to provide another structure to templates. * Based on _Global Data Files_ participants, use `before` in pagination to provide pagination by years.
* Add editorconfig. * Add eslint. * Add toml eslint plugin.
fe0aa2b to
7326b91
Compare
It can not parse nunjucks template within the permalink.
|
I’m on the road for a few days—will try to review in between but can’t tell yet. |
* Use array-like data to define what to get from the global data. This allows nunjucks filters. * Add globals for first and current year. * Add filters and clean config file a bit.
* Use smaller functions with a narrower scope. * Add comments to better explain functions.
Updated `js-yaml` and several dependencies in `package-lock.json` to latest versions, ensuring compatibility and resolving potential integrity issues. Marked additional dependencies with the `peer` attribute for enhanced accuracy. (This commit message was AI-generated.) Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Rearranged header links in `index.njk` and `year.njk` to ensure consistent navigation functionality. This change improves semantics and aligns the structure of both templates. (This commit message was AI-generated.) Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Updated the wording for archive URL references in the README to improve clarity. This ensures contributors can more easily understand how to document their participation. (This commit message was AI-generated.) Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
|
Finally getting to something here 🙂 Nice work! ❤️ Felt free to address an issue that came up with npm audit. Also fixed homepage links (had to be flipped so that subpages link back home). There’s still some issue that the main header “jumps” when navigating from homepage to subpages—may be the link, but couldn’t pinpoint it yet. Quick questions and observations (might be faster to just share here):
That just as a sign of life—will review again likely tomorrow, and should be much more available now! 🤝 |
|
Quick question, @arkhi—what would work best for you, if I make changes directly, comment in the PR, use good judgment, or no preferences at all? |
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Found the issue (commented web font line), pushed fix. Tested some more and tweaked a little. I like the approach of keeping things simple for the migration, for which this iteration looks good. The biggest points on my mind right now are these:
Both goes back to the last question though, from which I don’t want to distract 🙂
|
Yes! The intent is to have eleventy on prod before the end of the year, then we can hack better templates if we want and can.
I don’t see any issue with either. The idea being to stay open, it is also very unlikely someone new will forget to add their file, and others can find them easily.
Fact is the script on my website was on, so the website was actually naked, although I was not putting any effort in it. So, really, it’s just a facts vs. use/harm ratio, I guess. I see no harm, and if that gives a hint that others can join too, I think it’s a good thing. The data is there but we can tweak the templates if necessary, I won’t argue much more about either.
I don’t mind non-opinionated changes to be committed directly. The fixes you did are welcome, thanks! I spent some time on and off on this and it’s easy to miss the issues you spotted right away. The rewriting of some sentences was a bit off-putting but I’ll survive. :)
I’m in favour of both points. I’d rather:
Spending time optimising if the templates (ideally) change for the 2026 edition is something I’d like to avoid. |
|
@arkhi, then let’s go! Would not spend more time on this then, either. Took a few notes for improvements but can take it from there once we merged. Sorry if any change was surprising—happy if you want to revert or ask me to change anything back, and to chat more. Read everything as friendly and constructive 🙂 |
@alifeee made a proposal in a previous PR.
This is a different approach using structured data instead of HTML:
This PR does not touch master for now.
Things in this PR:
Some URL might lead to spam right now, but might have been totally legit websites at the time of submission. This is why some websites were not always removed.
Part of #160, closes #166.
From HTML to Toml files.
I used the following template and globalData to generate Toml files: