Skip to content

Conversation

@Matts966
Copy link
Contributor

@Matts966 Matts966 commented Jan 31, 2020

This PR introduces the CI process, in which all the tests are executed in docker container.

I fixed all the test cases, but the fix of failures in the spec of splitIdentifier may not be appropriate because I only changed the test cases, not the source codes. If the spec of splitIdentifier is wrong, could you please tell me it or fix it later 🙇

The status of CI will be displayed in README.md like

スクリーンショット 2020-02-03 15 03 17 スクリーンショット 2020-02-03 15 14 50

and we can check the output of tests in Actions menu like

スクリーンショット 2020-02-03 15 04 37 スクリーンショット 2020-02-03 15 36 24

Sorry for my not hearing about the acceptability of PRs. I will dispose of PRs if they are annoying.
Thank you for your great product!

@Matts966 Matts966 changed the title Fix all the tests other than cases of splitIdentifier and introduce the CI process Fix all the tests and introduce the CI process Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant