Remove set -x from gcc wrappers and fix behavior with 0 arguments #1728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are used very far down in the toolchain, where output is unexpected and often noisy due to how often these tools are invoked. Avoid printing unnecessary info.
`${@}` is a single word, regardless of how many arguments were passed to
the program. To expand it as an array, it must be `$@`.
See https://www.gnu.org/software/bash/manual/html_node/Shell-Expansions.html.
Fixes the following errors when invoked with 0 arguments:
```
docker/musl-gcc.sh: line 73: @: unbound variable
docker/freebsd-gcc.sh: line 16: @: unbound variable
```
Contributor
Author
|
I do want to note that the bug that |
Emilgardis
added
the
no-ci-targets
Emilgardis
approved these changes
Dec 12, 2025
Member
Emilgardis
left a comment
Emilgardis
left a comment
There was a problem hiding this comment.
let's merge this even though it's not required for newer versions :)
thank you!
Contributor
Author
|
thanks for the review! i'm hoping this in combination with a few other changes will let me turn rust-lang/rust#136096 back on in a release or two :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1618.
Additionally fixes the behavior when invoked with 0 arguments:
${@}is a single word, regardless of how many arguments were passed tothe program. To expand it as an array, it must be
$@.See https://www.gnu.org/software/bash/manual/html_node/Shell-Expansions.html.