Skip to content

Conversation

@relthyg
Copy link

@relthyg relthyg commented Dec 18, 2025

No description provided.

@relthyg relthyg marked this pull request as draft December 18, 2025 13:43
@romainnorberg
Copy link

+1 🙏

@relthyg If you're interested, I can help.

@relthyg
Copy link
Author

relthyg commented Jan 5, 2026

Hey @romainnorberg,

I'm still on winter break and don't really have an overview of the situation at the moment. I'll probably get back to it next week. Feel free to get started if you feel like and have time.

@knallcharge
Copy link

knallcharge commented Jan 9, 2026

I have tried to upgrade my project to Symfony 8 using this PR but found some issues:

  1. There are some "Fatal error: Declaration of x must be compatible with y"-errors displayed.
  2. Accessing the get()-method of an request was deprecated in Symfony 7.4 and will throw an "Attempted to call an undefined method named "get" of class "Symfony\Component\HttpFoundation\Request"."-error in Symfony 8.
  3. XML-configs are deprecated since Symfony 7.4.

I have tried to fix the issues, you may want to compare my fork:
master...knallcharge:CraueFormFlowBundle:master

One thing I could not quite figure out: line 628 in Form/FormFlow.php where the instanceId is fetched from the request. Not being familiar with the internals of this bundle I didn't know if this is expected from the GET- or the POST-variables so I implemented a switch. Don't know if this is necessary, maybe some can advice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants