Skip to content

Fix banner.php for PHP 8 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5TDg9 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix banner.php for PHP 8 #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions action/banner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,12 @@ function handle_display_banner(&$event, $param) {
return;
}

$meta = $INFO['meta'];
$meta = $INFO['meta'] ?? array();

if (!$meta['approval']) {
// Ensure the 'approval' key exists in the metadata array.
// On PHP 8, accessing a missing array key (e.g. $meta['approval'])
// triggers a "Undefined array key" warning, so we must check first.
if (!isset($meta['approval']) || !is_array($meta['approval'])) {
$meta['approval'] = array();
}

Expand Down