-
-
Notifications
You must be signed in to change notification settings - Fork 50
chore: move Cortex Linux core to BSL 1.1 license #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughAdds a Business Source License 1.1 document, replaces the root LICENSE with a short Apache 2.0 effective-date statement (Jan 15, 2032), updates README license text, and adjusts tests to reference and export several licensing-related symbols from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧹 Recent nitpick comments
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (2)**/*.py📄 CodeRabbit inference engine (AGENTS.md)
Files:
tests/**/*.py📄 CodeRabbit inference engine (AGENTS.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (6)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @mikejmorgan-ai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request transitions the Cortex Linux core to a Business Source License 1.1 model. This change aims to regulate commercial usage of the software by requiring commercial licenses for use beyond a single system or for production purposes, while still allowing certain free uses. The license also includes a clear path for the software to become Apache 2.0 licensed in the future, providing a structured approach to its long-term availability and use. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request transitions the Cortex Linux core license to Business Source License 1.1. The changes include adding a new BSL_LICENSE.md file with the full terms, updating the LICENSE file to be a concise pointer, and modifying the README.md to reflect the new licensing model. The changes are clear and consistent across the new and updated files. My main feedback is regarding an inconsistency in the README.md where the license badge at the top of the file was not updated and still refers to Apache 2.0, which could confuse users. This should be corrected to reflect the BSL 1.1 license.
| Cortex Linux is licensed under the **Business Source License 1.1 (BSL 1.1)**. | ||
|
|
||
| - Free use: **one (1) system** for personal, educational, contribution, or evaluation (up to **30 days**, including for-profit evaluation) | ||
| - Commercial use: any additional systems, production use, managed services, or competing offerings require a commercial license | ||
| - Change Date: **January 15, 2032** → **Apache 2.0** | ||
|
|
||
| See **BSL_LICENSE.md** for full terms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
17-17: Update license badge to reflect BSL 1.1.The badge currently displays "Apache 2.0" but the project is licensed under BSL 1.1 until January 15, 2032. This inconsistency could mislead users about the actual license terms and restrictions.
🏷️ Proposed fix to update the badge
- <img src="https://img.shields.io/badge/License-Apache%202.0-blue.svg" alt="License" /> + <img src="https://img.shields.io/badge/License-BSL%201.1-blue.svg" alt="License" />
🧹 Nitpick comments (1)
BSL_LICENSE.md (1)
91-91: Consider wrapping bare URLs in markdown link syntax.Markdownlint prefers explicit link syntax for URLs (note: line 91 is an email address and should remain as-is).
♻️ Proposed formatting improvements
For commercial licensing inquiries: licensing@cortexlinux.com Pricing information: -https://cortexlinux.com/pricing +[https://cortexlinux.com/pricing](https://cortexlinux.com/pricing)This license is based on the Business Source License 1.1, originally published by MariaDB Corporation. -https://mariadb.com/bsl11/ +[https://mariadb.com/bsl11/](https://mariadb.com/bsl11/)Also applies to: 94-94, 126-126
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
BSL_LICENSE.mdLICENSEREADME.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
BSL_LICENSE.md
91-91: Bare URL used
(MD034, no-bare-urls)
94-94: Bare URL used
(MD034, no-bare-urls)
126-126: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Test (Python 3.12)
- GitHub Check: Test (Python 3.10)
- GitHub Check: Test (Python 3.11)
- GitHub Check: test (3.10)
- GitHub Check: test (3.11)
- GitHub Check: test (3.12)
🔇 Additional comments (2)
README.md (1)
462-468: LGTM! License description is clear and accurate.The license section accurately reflects the BSL 1.1 terms, including the one-system limitation, commercial use requirements, and the Change Date for Apache 2.0 conversion. The reference to BSL_LICENSE.md provides users with a clear path to the full terms.
LICENSE (1)
1-7: LGTM! Clear and concise license summary.The summary-style LICENSE file effectively directs users to the full BSL 1.1 terms in BSL_LICENSE.md while noting the commercial licensing path and future Apache 2.0 conversion. This approach is appropriate for projects with detailed license terms in a separate document.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
CLA Verification PassedAll contributors have signed the CLA.
|
|



Summary
This PR adopts Business Source License 1.1 (BSL 1.1) for Cortex Linux core.
What changed
Commercial licensing
Summary by CodeRabbit
Chores
Documentation
Tests
✏️ Tip: You can customize this high-level summary in your review settings.