chore: Auto-fix 152 ruff linting issues #610
Conversation
mikejmorgan-ai
requested review from
Anshgrover23 and
Suyashd999
as code owners
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughModernizes type hints across many modules to use built-in generics and PEP 604 union syntax; adjusts import ordering in places; broadens a few I/O exception handlers; and adds a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (15)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @mikejmorgan-ai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the codebase's adherence to modern Python style and best practices by automatically fixing numerous linting issues. The changes primarily focus on standardizing import order and updating type hints to their contemporary forms, enhancing code readability and maintainability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a series of automated style fixes using ruff, which significantly improves code consistency and readability across 15 files. The changes primarily focus on modernizing type annotations (e.g., list instead of typing.List, X | None instead of Optional[X]), optimizing import statements, and removing unnecessary f-strings.
My review confirms that all the automated changes are correct and beneficial, adhering to modern Python best practices. The codebase is cleaner and more maintainable as a result. This is a great cleanup effort. Well done!
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| from rich.table import Table | ||
|
|
||
| from cortex.branding import console, cx_print, cx_header, CORTEX_CYAN | ||
| from cortex.branding import CORTEX_CYAN, console, cx_header, cx_print |
| import os | ||
| import subprocess | ||
| import time | ||
| from collections.abc import Callable |
| from enum import Enum | ||
| from pathlib import Path | ||
| from typing import Callable, Optional | ||
| from typing import Optional |
| from dataclasses import dataclass, field | ||
| from enum import Enum | ||
| from typing import Any, Generator, List, Optional, Tuple | ||
| from typing import Any, List, Optional, Tuple |
| from enum import Enum | ||
| from pathlib import Path | ||
| from typing import Callable, Optional | ||
| from typing import Optional |
| with open(self.history_path, "w") as f: | ||
| json.dump(history, f, indent=2) | ||
| except IOError: | ||
| except OSError: |
- Sort imports (I001) - Replace deprecated typing imports (UP035) - Use modern type annotations (UP006, UP045) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mikejmorgan-ai
force-pushed
the
fix/ruff-autofix
branch
from
d017f97 to
9eed04d
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
cortex/benchmark.py (1)
18-18: UnusedList,Optional,Tupleimports causing pipeline failure.The pipeline is failing with
UP035 'typing.List' is deprecated. After the type hint modernization,List,Optional, andTupleare no longer used—onlyAnyis still needed from typing.Suggested fix
-from typing import Any, List, Optional, Tuple +from typing import Anycortex/systemd_helper.py (1)
16-16: Remove unusedtypingimports from line 16.All imports (
Any,Dict,List,Optional,Tuple) are unused. They appear only in docstring text, not in actual type annotations.Suggested fix
-from typing import Any, Dict, List, Optional, Tuplecortex/gpu_manager.py (1)
16-16: Remove all unused typing imports.All imports on line 16 (
Any,Dict,List,Optional,Tuple) are unused after type hint modernization. The codebase now uses PEP 585 and PEP 604 style type hints (lowercaselist,dict,tuple, and|for unions).♻️ Suggested fix
-from typing import Any, Dict, List, Optional, Tuple
🤖 Fix all issues with AI agents
In `@cortex/output_formatter.py`:
- Around line 10-14: Remove deprecated typing imports by deleting List, Tuple,
and Optional from the typing import in cortex/output_formatter.py; if typing.Any
is also unused, remove the entire "from typing import ..." line. Ensure you keep
the valid imports already added (Generator from collections.abc, contextmanager,
dataclass, field, Enum) and only import types that are actually referenced by
functions/classes in this module.
🧹 Nitpick comments (10)
cortex/wifi_driver.py (1)
14-14: UnusedOptionalimport after modernization.The
Optionalimport is no longer used sincefind_drivernow usesDriverInfo | Nonesyntax. This should be removed as part of the cleanup.Suggested fix
-from typing import Optionalcortex/stdin_handler.py (1)
17-17: UnusedOptionalimport after modernization.The
Optionalimport is no longer used sincedisplay_stdin_infonow usesdict | Nonesyntax.Suggested fix
-from typing import Optionalcortex/health_score.py (1)
18-18: UnusedOptionalimport.The
Optionalimport is not used anywhere in this file and should be removed.Suggested fix
-from typing import Optionalcortex/licensing.py (1)
7-7: UnusedOptionalimport after modernization.The
Optionalimport is no longer used since all type hints now useX | Nonesyntax.Suggested fix
-from typing import Optionalcortex/semver_resolver.py (1)
13-13: UnusedOptionalimport after modernization.The
Optionalimport is no longer used since all type hints now useX | Nonesyntax.Suggested fix
-from typing import Optionalcortex/version_manager.py (1)
12-12: UnusedOptionalimport after type hint modernization.The
Optionalimport is no longer used since lines 32-33 now usestr | Nonesyntax. This appears to be one of the 15 remaining issues mentioned in the PR description that require manual removal.Suggested fix
-from typing import Optionalcortex/update_checker.py (1)
15-15: UnusedOptionalimport after type hint modernization.The
Optionalimport is no longer used since all usages have been converted toX | Noneunion syntax.Suggested fix
-from typing import Optionalcortex/updater.py (1)
21-21: UnusedOptionalimport after type hint modernization.The
Optionalimport is no longer used since all usages have been converted toX | Noneunion syntax.Suggested fix
-from typing import Optionalcortex/branding.py (1)
14-14: Unused imports remain after type hint modernization.The imports
List,Optional, andTuplefromtypingare no longer used after converting all type hints to Python 3.9+ built-in generics (list,tuple) and PEP 604 union syntax (X | None). This matches the PR description noting "Fifteen remaining issues require manual review due to deprecated typing imports still in use."♻️ Suggested fix
-from typing import List, Optional, Tuplecortex/printer_setup.py (1)
14-14: Unused imports remain after type hint modernization.The imports
Dict,List,Optional, andTuplefromtypingare no longer used since all type hints have been converted to built-in generics and union syntax.♻️ Suggested fix
-from typing import Dict, List, Optional, Tuple
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
cortex/benchmark.pycortex/branding.pycortex/cli.pycortex/gpu_manager.pycortex/health_score.pycortex/licensing.pycortex/output_formatter.pycortex/printer_setup.pycortex/semver_resolver.pycortex/stdin_handler.pycortex/systemd_helper.pycortex/update_checker.pycortex/updater.pycortex/version_manager.pycortex/wifi_driver.py
🧰 Additional context used
📓 Path-based instructions (1)
**/*.py
📄 CodeRabbit inference engine (AGENTS.md)
**/*.py: Follow PEP 8 style guide for Python code
Include type hints in Python code
Add docstrings for all public APIs in Python code
Use dry-run mode by default for all installation operations
Do not use silent sudo - require explicit user confirmation for privilege escalation
Implement Firejail sandboxing for execution of untrusted code
Log all operations to ~/.cortex/history.db for audit purposes
Files:
cortex/wifi_driver.pycortex/cli.pycortex/update_checker.pycortex/licensing.pycortex/version_manager.pycortex/branding.pycortex/gpu_manager.pycortex/health_score.pycortex/semver_resolver.pycortex/benchmark.pycortex/systemd_helper.pycortex/printer_setup.pycortex/output_formatter.pycortex/updater.pycortex/stdin_handler.py
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: cortexlinux/cortex PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-12T20:51:13.828Z
Learning: Applies to **/*.py : Include type hints in Python code
🧬 Code graph analysis (6)
cortex/wifi_driver.py (1)
cortex/printer_setup.py (2)
find_driver(291-320)DriverInfo(60-66)
cortex/cli.py (4)
cortex/version_manager.py (2)
UpdateChannel(18-21)get_version_string(152-154)cortex/update_checker.py (1)
should_notify_update(371-391)cortex/updater.py (1)
UpdateStatus(43-52)cortex/branding.py (1)
cx_print(64-84)
cortex/update_checker.py (1)
cortex/version_manager.py (1)
SemanticVersion(26-144)
cortex/gpu_manager.py (3)
cortex/health_score.py (1)
_run_command(146-163)cortex/printer_setup.py (1)
_run_command(106-119)cortex/wifi_driver.py (1)
_run_command(193-210)
cortex/benchmark.py (2)
cortex/branding.py (2)
cx_header(97-103)cx_print(64-84)cortex/health_score.py (1)
overall_score(95-105)
cortex/updater.py (3)
cortex/progress_indicators.py (1)
duration_seconds(77-82)cortex/cli.py (4)
progress_callback(885-892)progress_callback(1243-1247)progress_callback(2378-2384)progress_callback(2411-2418)cortex/update_checker.py (1)
ReleaseInfo(40-98)
🪛 GitHub Actions: CI
cortex/benchmark.py
[error] 18-18: UP035 typing.List is deprecated, use list instead.
🪛 GitHub Check: lint
cortex/output_formatter.py
[failure] 14-14: Ruff (UP035)
cortex/output_formatter.py:14:1: UP035 typing.Tuple is deprecated, use tuple instead
[failure] 14-14: Ruff (UP035)
cortex/output_formatter.py:14:1: UP035 typing.List is deprecated, use list instead
🪛 GitHub Check: Lint
cortex/output_formatter.py
[failure] 14-14: Ruff (UP035)
cortex/output_formatter.py:14:1: UP035 typing.Tuple is deprecated, use tuple instead
[failure] 14-14: Ruff (UP035)
cortex/output_formatter.py:14:1: UP035 typing.List is deprecated, use list instead
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: test (3.12)
- GitHub Check: test (3.10)
- GitHub Check: test (3.11)
🔇 Additional comments (65)
cortex/wifi_driver.py (1)
330-330: LGTM!The return type annotation modernization to
DriverInfo | Noneis correct and consistent with the same pattern used incortex/printer_setup.py.cortex/stdin_handler.py (2)
107-108: LGTM!Since Python 3.3,
IOErroris an alias forOSError, so catching onlyOSErroris correct and cleaner.
312-312: LGTM!The parameter type annotation modernization to
dict | Noneis correct.cortex/health_score.py (4)
13-13: LGTM!Importing
Callablefromcollections.abcinstead oftypingaligns with PEP 585 recommendations for Python 3.9+.
481-482: LGTM!The exception handling modernization from
IOErrortoOSErroris correct. Thejson.JSONDecodeErroris appropriately retained for JSON parsing errors.
501-502: LGTM!Correct modernization of exception handling.
512-513: LGTM!Consistent exception handling modernization with
JSONDecodeErrorappropriately retained.cortex/licensing.py (5)
84-86: LGTM!The parameter type annotations are correctly modernized to PEP 604 union syntax.
110-110: LGTM!Module-level type annotation correctly modernized.
254-254: LGTM!Using a plain string instead of an f-string when no interpolation is needed is a minor cleanup.
295-295: LGTM!Plain string usage is appropriate here.
306-306: LGTM!Plain string usage is appropriate here.
cortex/semver_resolver.py (6)
120-121: LGTM!Dataclass field type annotations correctly modernized to PEP 604 syntax.
187-187: LGTM!Dataclass field type annotation correctly modernized.
264-264: LGTM!Return type annotation correctly modernized.
286-286: LGTM!Return type annotation correctly modernized.
515-517: LGTM!Return type annotation correctly modernized.
618-618: LGTM!Parameter type annotation correctly modernized using built-in
listgeneric and PEP 604 union syntax.cortex/version_manager.py (1)
32-33: LGTM!The type annotations are correctly modernized to PEP 604 union syntax (
str | None).cortex/update_checker.py (1)
49-50: LGTM!All type annotations are correctly modernized:
str | Nonefor optional fieldsSemanticVersion | None,ReleaseInfo | Nonefor optional complex typesUpdateCheckResult | Nonefor return typesAlso applies to: 107-111, 132-132, 371-371
cortex/benchmark.py (1)
23-26: LGTM!Import reordering and type hint modernization are correct:
- Built-in
list[...]replacesList[...]- Built-in
tuple[...]replacesTuple[...]- Imports follow proper ordering conventions
Also applies to: 60-60, 63-64, 98-98, 421-421, 466-468
cortex/updater.py (2)
16-16: Good practice:Callableimported fromcollections.abc.Using
collections.abc.Callableinstead oftyping.Callablealigns with Python 3.9+ best practices wheretyping.Callableis deprecated.
62-65: LGTM!All type annotations are correctly modernized to PEP 604 union syntax and use proper
Callabletyping.Also applies to: 84-84, 120-120, 254-254, 468-468
cortex/systemd_helper.py (2)
102-113: LGTM!Dataclass field annotations are correctly modernized:
str | Nonefor optional string fieldsdict[str, str]for environment mappinglist[str]for collection fields- Proper use of
field(default_factory=...)for mutable defaultsAlso applies to: 133-133
153-153: LGTM!Method signatures correctly modernized:
- Return types use
tuple[...]instead ofTuple[...]- Optional returns use
ServiceStatus | None- Dictionary returns use
dict[str, list[str]]Also applies to: 182-182, 240-240, 297-297, 348-348, 355-355, 473-476
cortex/cli.py (3)
31-34: LGTM - Import reordering applied.The imports from
cortex.update_checker,cortex.updater, andcortex.version_managerhave been reorganized, likely for import sorting compliance (I001). The functionality remains unchanged.
1221-1227: LGTM - Minor text formatting updates.The console output messages for release notes and upgrade instructions are consistent with the rest of the CLI output style.
2548-2549: LGTM - Update notification message.The startup update notification message formatting is consistent.
cortex/branding.py (5)
142-147: LGTM - Type hints modernized forcx_box.The
titleandsubtitleparameters now use Python 3.10+ union syntax (str | None) instead ofOptional[str].
176-179: LGTM - Type hints modernized forcx_status_box.The
itemsparameter now uses built-inlist[tuple[str, str, str]]instead ofList[Tuple[str, str, str]].
223-228: LGTM - Type hints modernized forcx_table.Parameters updated to use built-in generics and union syntax:
list[str],list[list[str]],str | None,list[str] | None.
257-260: LGTM - Type hints modernized forcx_package_table.The
packagesparameter now useslist[tuple[str, str, str]].
296-296: LGTM - Type hints modernized forcx_divider.The
titleparameter now usesstr | Noneinstead ofOptional[str].cortex/printer_setup.py (11)
21-21: LGTM - Import reordering.Branding imports reorganized for import sorting compliance.
106-119: LGTM - Type hints modernized for_run_command.The method signature now uses
list[str]forcmdandtuple[int, str, str]for the return type.
131-172: LGTM - Type hints modernized fordetect_usb_printers.Return type updated to
list[PrinterDevice].
174-199: LGTM - Type hints modernized fordetect_network_printers.Return type updated to
list[PrinterDevice].
201-235: LGTM - Type hints modernized fordetect_configured_printers.Return type updated to
list[PrinterDevice].
237-268: LGTM - Type hints modernized fordetect_scanners.Return type updated to
list[PrinterDevice].
291-320: LGTM - Type hints modernized forfind_driver.Return type updated to
DriverInfo | None.
322-334: LGTM - Type hints modernized forget_driver_packages.Return type updated to
list[str].
336-396: LGTM - Type hints modernized forsetup_printer.Parameter
driverupdated toDriverInfo | Noneand return type totuple[bool, str].
398-412: LGTM - Type hints modernized fortest_print.Return type updated to
tuple[bool, str].
414-428: LGTM - Type hints modernized fortest_scan.Parameter
scanner_uriupdated tostr | Noneand return type totuple[bool, str].cortex/gpu_manager.py (10)
23-23: LGTM - Import reordering.Branding imports reorganized for import sorting compliance.
59-68: LGTM - Type hints modernized forGPUStatedataclass.Fields updated:
devices: list[GPUDevice]andactive_gpu: GPUDevice | None.
79-87: LGTM - Type hints modernized forAppGPUConfigdataclass.Field updated:
env_vars: dict[str, str].
127-144: LGTM - Type hints modernized forHybridGPUManager.__init__and_run_command.Instance variable
_stateand method signature updated to use modern type hints.
146-173: LGTM - Type hints modernized fordetect_gpus.Return type updated to
list[GPUDevice].
175-201: LGTM - Type hints modernized for_parse_lspci_line.Return type updated to
GPUDevice | None.
203-231: LGTM - Type hints modernized for_detect_nvidia_gpu.Return type updated to
GPUDevice | None.
295-356: LGTM - Type hints modernized forswitch_mode.Return type updated to
tuple[bool, str, str | None].
388-390: LGTM - Type hints modernized forget_battery_estimate.Return type updated to
dict[str, str].
520-524: LGTM - Type hints modernized forrun_gpu_manager.Parameter
modeupdated tostr | None = None.cortex/output_formatter.py (11)
79-87: LGTM - Type hints modernized forTableColumndataclass.Field
widthupdated toint | None.
99-143: LGTM - Type hints modernized forformat_box.Parameters updated:
title: str | None,subtitle: str | None,padding: tuple[int, int].
146-196: LGTM - Type hints modernized forformat_status_box.Parameter updated:
items: list[StatusInfo].
199-244: LGTM - Type hints modernized forformat_table.Parameters updated:
columns: list[TableColumn],rows: list[list[str]],title: str | None,row_styles: list[str] | None.
247-268: LGTM - Type hints modernized forformat_package_table.Parameter updated:
packages: list[tuple[str, str, str]].
271-304: LGTM - Type hints modernized forformat_dependency_tree.Parameter updated:
title: str | None.
307-339: LGTM - Type hints modernized forspinner_context.Parameters updated:
success_message: str | None,error_message: str | None. Return type correctly usesGenerator[Status, None, None]fromcollections.abc.
354-364: LGTM - Type hints modernized forProgressTracker.__init__.Parameter and instance variables updated:
total: int | None,_progress: Progress | None,_task_id: TaskID | None.
391-398: LGTM - Type hints modernized forProgressTracker.update.Parameter updated:
description: str | None.
424-428: LGTM - Type hints modernized forMultiStepProgress.__init__.Parameter and instance variables updated:
steps: list[str],step_status: dict,_live: Live | None. Thedict.fromkeys(steps, "pending")initialization is equivalent to the previous dict comprehension.
527-542: LGTM - Type hints modernized for helper functions.
print_status_box,print_table, andprint_dividersignatures updated to uselist[...]andstr | None.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| from collections.abc import Generator | ||
| from contextlib import contextmanager | ||
| from dataclasses import dataclass, field | ||
| from enum import Enum | ||
| from typing import Any, Generator, List, Optional, Tuple | ||
| from typing import Any, List, Optional, Tuple |
There was a problem hiding this comment.
Static analysis flagged deprecated typing imports.
Per the linting hints, line 14 still imports List and Tuple from typing (UP035: deprecated). After the type hint modernization, List, Optional, and Tuple are no longer used. The addition of Generator from collections.abc on line 10 is correct.
🔧 Suggested fix
from collections.abc import Generator
from contextlib import contextmanager
from dataclasses import dataclass, field
from enum import Enum
-from typing import Any, List, Optional, Tuple
+from typing import AnyIf Any is also unused, remove the entire import line.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| from collections.abc import Generator | |
| from contextlib import contextmanager | |
| from dataclasses import dataclass, field | |
| from enum import Enum | |
| from typing import Any, Generator, List, Optional, Tuple | |
| from typing import Any, List, Optional, Tuple | |
| from collections.abc import Generator | |
| from contextlib import contextmanager | |
| from dataclasses import dataclass, field | |
| from enum import Enum | |
| from typing import Any |
🧰 Tools
🪛 GitHub Check: lint
[failure] 14-14: Ruff (UP035)
cortex/output_formatter.py:14:1: UP035 typing.Tuple is deprecated, use tuple instead
[failure] 14-14: Ruff (UP035)
cortex/output_formatter.py:14:1: UP035 typing.List is deprecated, use list instead
🪛 GitHub Check: Lint
[failure] 14-14: Ruff (UP035)
cortex/output_formatter.py:14:1: UP035 typing.Tuple is deprecated, use tuple instead
[failure] 14-14: Ruff (UP035)
cortex/output_formatter.py:14:1: UP035 typing.List is deprecated, use list instead
🤖 Prompt for AI Agents
In `@cortex/output_formatter.py` around lines 10 - 14, Remove deprecated typing
imports by deleting List, Tuple, and Optional from the typing import in
cortex/output_formatter.py; if typing.Any is also unused, remove the entire
"from typing import ..." line. Ensure you keep the valid imports already added
(Generator from collections.abc, contextmanager, dataclass, field, Enum) and
only import types that are actually referenced by functions/classes in this
module.
|
Closes #609
Summary
Auto-fixed 152 style issues using
ruff check --fix.Changes
typing.List→list,typing.Dict→dictOptional[X]→X | NoneFiles Modified
15 files across the codebase
Remaining
15 issues require manual review (deprecated typing imports still in use)
Bounty: $50 (+ $50 bonus after funding)
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.