-
-
Notifications
You must be signed in to change notification settings - Fork 50
feat: Added voice feature for end-user fix #325 #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sahilbhatane
wants to merge
28
commits into
cortexlinux:main
Choose a base branch
from
Sahilbhatane:issue-325
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
50d92cf
Voice feature: speeech-to-text added
Sahilbhatane 9acb0d7
Merge branch 'cortexlinux:main' into issue-325
Sahilbhatane bb1de82
test fixs
Sahilbhatane 891dff5
chore: add myenv and venv312 to gitignore
Sahilbhatane 1734cff
fix: remove myenv from repo and fix voice test mocking
Sahilbhatane dab189b
docs: remove tiny.en model, use base.en as default everywhere
Sahilbhatane b66f6c0
fix: address Copilot and CodeRabbit review comments
Sahilbhatane 45d3769
fix: skip voice tests when numpy not installed (optional dep)
Sahilbhatane 8f2384f
Merge branch 'cortexlinux:main' into issue-325
Sahilbhatane 12e7208
Merge branch 'main' into issue-325
Sahilbhatane 3ae13dd
Suggestion fix and import fix
Sahilbhatane 4837e51
Add import for error
Sahilbhatane 73a734f
System requirements for voice and key detection
Sahilbhatane 0cd18a1
test fix for py 3.11
Sahilbhatane 1abb28e
Test fix and consolidate package installations
Sahilbhatane 9645134
Merge branch 'main' into issue-325
Sahilbhatane 0de57d2
fix: Code review fixes for PR #405
Sahilbhatane f55bd8c
fix: SonarCloud reliability improvements
Sahilbhatane 7e49182
refactor: Reduce cognitive complexity in install method
Sahilbhatane 2563901
fix: Remove unused variable and clean imports in voice.py
Sahilbhatane e322815
test: Clean up unused variables in test_voice.py
Sahilbhatane c4dffe5
fix: Extract 'Installation failed' constant to eliminate duplication
Sahilbhatane 6bb4173
fix: Remove unused fixture parameters from voice tests
Sahilbhatane 758299d
black formating for lint
Sahilbhatane d771562
fix: VoiceInputHandler resources are always cleaned up
Sahilbhatane 580eb76
remove duplicate package
Sahilbhatane 83f3360
user choice for model selection
Sahilbhatane 1934d19
suggstion fix
Sahilbhatane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,8 @@ __pycache__/ | |
| # ============================== | ||
| env/ | ||
| venv/ | ||
| myenv/ | ||
| venv312/ | ||
| ENV/ | ||
| env.bak/ | ||
| venv.bak/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: cortexlinux/cortex
Length of output: 5200
Critical: Virtual environment files committed to git; .gitignore change is incomplete.
The
myenv/directory with virtual environment artifacts (activation scripts,pyvenv.cfg, executables, man pages) is already committed in this PR. Addingmyenv/andvenv312/to.gitignoreprevents future commits but does not remove these files from git history.These directories must be removed from the commit before merging. Use
git rm -r --cached myenv/ venv312/and amend the commit, or rebase to exclude them entirely. Without this cleanup, the repository will include unnecessary virtual environment files that violate the project's policy of never committing local development environments.🤖 Prompt for AI Agents