Remove ceda_usa folder #72
Conversation
| uses: ./.github/actions/setup-python | ||
|
|
||
| - name: Typecheck w/ mypy | ||
| run: uv run mypy bedrock/ceda_usa |
There was a problem hiding this comment.
@cclin130 since I'm removing the entire ceda_usa folder, so here I changed it to /extract/iot. LMK if this looks wrong to you.
There was a problem hiding this comment.
we should run mypy on the whole repo, but types havent been set up yet for all of bedrock I believe. Perhaps we could make this uv run mypy bedrock but then add a line to exclude some directories for now in pyproject.toml
cc @bl-young
| uses: ./.github/actions/setup-python | ||
|
|
||
| - name: Typecheck w/ mypy | ||
| run: uv run mypy bedrock/ceda_usa |
There was a problem hiding this comment.
we should run mypy on the whole repo, but types havent been set up yet for all of bedrock I believe. Perhaps we could make this uv run mypy bedrock but then add a line to exclude some directories for now in pyproject.toml
cc @bl-young
MoLi7
force-pushed
the
mo__rm-ceda-usa-folder
branch
from
7ec9ac2 to
1f4ff37
Compare
|
|
||
| - name: Typecheck w/ mypy | ||
| run: uv run mypy bedrock/ceda_usa | ||
| run: uv run mypy bedrock |
| 'bedrock/transform/', | ||
| 'bedrock/utils/', | ||
| 'bedrock/publish/', | ||
| ] |
There was a problem hiding this comment.
this is effectively ignoring all of the CEDA code as well, right? does it need to be so exhaustive?
and what do we have in /utils/ and /publish that are failing type check right now?
i would like us to avoid putting the typecheck here and never fixing it, because it will render typecheck useless
cc @bl-young since I know this is on your radar
| "google.*", | ||
| "googleapiclient.*", | ||
| ] | ||
| ignore_missing_imports = true |
|
r? @cclin130 |
cclin130
left a comment
cclin130
left a comment
There was a problem hiding this comment.
approving to unblock but i'd recommend getting typecheck to work across the whole codebase
| 'bedrock/transform/', | ||
| 'bedrock/utils/', | ||
| 'bedrock/publish/', | ||
| ] |
There was a problem hiding this comment.
this is effectively ignoring all of the CEDA code as well, right? does it need to be so exhaustive?
and what do we have in /utils/ and /publish that are failing type check right now?
i would like us to avoid putting the typecheck here and never fixing it, because it will render typecheck useless
cc @bl-young since I know this is on your radar
cc:
What changed? Why?
Removed the
ceda_usapackage from thebedrockdirectory, which should've been removed long time ago.Testing
confirming no one imports from
bedrock.ceda_usa