-
Notifications
You must be signed in to change notification settings - Fork 37
aib: update params to sync with upstream #952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAligns local documentation and test scripts with the current automotive-image-builder (AIB) CLI by updating File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @dougsland, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
should resolve: #951 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- The AIB invocation is now duplicated (README and check_qm_with_aib.sh); consider centralizing the command or key options in a single place to avoid future drift when upstream changes again.
- By removing
--export qcow2and changing the--targetposition, ensure any consumers of the qcow2 artifact (paths, names, or formats) still match what the tests and tooling expect, otherwise you may want to document or guard against those assumptions in the script.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The AIB invocation is now duplicated (README and check_qm_with_aib.sh); consider centralizing the command or key options in a single place to avoid future drift when upstream changes again.
- By removing `--export qcow2` and changing the `--target` position, ensure any consumers of the qcow2 artifact (paths, names, or formats) still match what the tests and tooling expect, otherwise you may want to document or guard against those assumptions in the script.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates calls to auto-image-builder.sh by removing the --export qcow2 parameter to align with upstream changes. The update is consistently applied to both the developer documentation and a test script.
I have two main points of feedback. First, for the documentation, I suggest reformatting a long command to improve readability. Second, and more importantly, I've identified a command injection vulnerability in the test script due to the use of eval with an environment variable and have provided a safer alternative. Addressing this security issue is highly recommended.
48f746a to
12a6c58
Compare
Avoid tests breakage. Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
12a6c58 to
32579f9
Compare
I think we need two issues to handle the comments from bot. @Yarboa WDYT? |
ArtiomDivak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored: yarboa@gmail.com
Avoid tests breakage.
Summary by Sourcery
fix #951
Align automotive-image-builder invocation parameters with upstream usage in documentation and tests to prevent breakage.
Enhancements: