Skip to content

Conversation

@dougsland
Copy link
Member

@dougsland dougsland commented Dec 19, 2025

Avoid tests breakage.

Summary by Sourcery

fix #951

Align automotive-image-builder invocation parameters with upstream usage in documentation and tests to prevent breakage.

Enhancements:

  • Update README developer instructions to remove the deprecated --export qcow2 option and adjust build command parameters.
  • Update AIB test script to match the current upstream build command by dropping the --export qcow2 flag.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 19, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Aligns local documentation and test scripts with the current automotive-image-builder (AIB) CLI by updating build command arguments and removing deprecated --export qcow2 usage where it is no longer valid.

File-Level Changes

Change Details Files
Update documented AIB build command to match current upstream CLI signature for qemu target builds.
  • Removed the deprecated or invalid --export qcow2 flag from the documented auto-image-builder.sh build invocation for qemu targets.
  • Adjusted the position of the --target qemu option so that it precedes the positional arguments, matching the current upstream AIB command syntax.
  • Kept all existing --define parameters and repository/rpm configuration intact while updating only the CLI shape.
docs/devel/README.developer.md
Update AIB test helper script to use the current AIB CLI syntax for building qcow2 images.
  • Removed the --export qcow2 flag from the test script's AIB build invocation, assuming the current upstream automatically infers qcow2 or no longer accepts this flag.
  • Maintained use of the EXTRA_REPOS definition and image/input filenames while updating only the argument list to avoid test breakage with the new CLI.
tests/aib/check_qm_with_aib.sh

Possibly linked issues

  • #: PR updates AIB build command options to match upstream, directly addressing the CI test failures described in issue
  • #(unassigned): PR updates auto-image-builder.sh command-line parameters in docs and tests, matching upstream and fixing the AIB gate failure.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist
Copy link

Summary of Changes

Hello @dougsland, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the auto-image-builder.sh command parameters across the developer documentation and a specific test script. The primary purpose of this modification is to remove the --export qcow2 flag, ensuring that the commands remain compatible with the latest upstream version of the image builder and preventing potential test failures.

Highlights

  • Parameter Update: The --export qcow2 parameter has been removed from the auto-image-builder.sh build command.
  • Synchronization with Upstream: This change aligns the command usage in both documentation and test scripts with recent upstream modifications to auto-image-builder.sh.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dougsland
Copy link
Member Author

should resolve: #951

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The AIB invocation is now duplicated (README and check_qm_with_aib.sh); consider centralizing the command or key options in a single place to avoid future drift when upstream changes again.
  • By removing --export qcow2 and changing the --target position, ensure any consumers of the qcow2 artifact (paths, names, or formats) still match what the tests and tooling expect, otherwise you may want to document or guard against those assumptions in the script.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The AIB invocation is now duplicated (README and check_qm_with_aib.sh); consider centralizing the command or key options in a single place to avoid future drift when upstream changes again.
- By removing `--export qcow2` and changing the `--target` position, ensure any consumers of the qcow2 artifact (paths, names, or formats) still match what the tests and tooling expect, otherwise you may want to document or guard against those assumptions in the script.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates calls to auto-image-builder.sh by removing the --export qcow2 parameter to align with upstream changes. The update is consistently applied to both the developer documentation and a test script.

I have two main points of feedback. First, for the documentation, I suggest reformatting a long command to improve readability. Second, and more importantly, I've identified a command injection vulnerability in the test script due to the use of eval with an environment variable and have provided a safer alternative. Addressing this security issue is highly recommended.

@dougsland dougsland force-pushed the exportqcow2 branch 2 times, most recently from 48f746a to 12a6c58 Compare December 19, 2025 16:35
Avoid tests breakage.

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
@dougsland
Copy link
Member Author

Code Review

This pull request updates calls to auto-image-builder.sh by removing the --export qcow2 parameter to align with upstream changes. The update is consistently applied to both the developer documentation and a test script.

I have two main points of feedback. First, for the documentation, I suggest reformatting a long command to improve readability. Second, and more importantly, I've identified a command injection vulnerability in the test script due to the use of eval with an environment variable and have provided a safer alternative. Addressing this security issue is highly recommended.

I think we need two issues to handle the comments from bot. @Yarboa WDYT?

Copy link
Collaborator

@ArtiomDivak ArtiomDivak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-Authored: yarboa@gmail.com
@dougsland dougsland merged commit 8f99f29 into main Dec 22, 2025
27 checks passed
@dougsland dougsland deleted the exportqcow2 branch December 22, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Aib issue in qm

4 participants