Respect digests.Options in sif:, tarball:, and for configs in docker-daemon: and docker-archive: #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to allow building the digest-choice-dependent machinery from the bottom up without committing to an API while we don't understand the problem space; for now, we don't expose any way for users to actually make a choice. This code is never called at this point, so this should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
for now, purely to let us internally work on implementing digest choice / conversions; there is no way for a caller to set it. Should not change behavior, the field has no users. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Currently it is only called in oci/archive and openshift to forward to another transport; real users will be added later. Should not change behavior (yet). Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This will make it a bit easier to use NewImageSourceOptions for transports that might only implement the public types.ImageReference. This commit does not (yet) add any callers, so this should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…r-daemon: Note that we DO NOT use options.Digest for the layer IDs; that would require extra CPU cost to digest files more than once. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Contributor
Author
|
Not to self: Absolutely untested at this point. |
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Dec 6, 2025
|
✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6574 |
|
Packit jobs failed. @containers/packit-build please check. |
1 similar comment
|
Packit jobs failed. @containers/packit-build please check. |
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: This is on top of #530 .
Add
private.ImageReference.NewImageSourceWithOptions, and use it to passdigests.Optionsto transports that might need to compute digests.Fully implement that in
sif:andtarball:.For
docker-deamon:anddocker-archive:, usedigests.Optionsfor the config digest, but do not use it for layers, to avoid an extra cost. See the detailed added comment for rationale. This also does not modify the destination parts of these transports at all.Also 2 sort-of-unrelated bug fixes.
See individual commit messages for details.
Cc: @lsm5 (low priority)