fix(deparser): quote schema name in CreateSchemaStmt #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
CreateSchemaStmthandler was not quoting the schema name, which caused parse errors when the schema name contained special characters like hyphens.Before:
CREATE SCHEMA constructive-public;(invalid SQL - hyphen interpreted as minus operator)After:
CREATE SCHEMA "constructive-public";(valid SQL)This fix uses
QuoteUtils.quoteIdentifier()to properly quote schema names that require quoting, consistent with how other identifiers are handled elsewhere in the deparser (e.g., in sequence statements at lines 9346 and 9387).Review & Testing Checklist for Human
pnpm testinpackages/deparser(note: there are 12 pre-existing test failures unrelated to this change)CreateSchemaStmtwith special characters in schema namespublic) are NOT unnecessarily quoted after this changeTest plan:
Notes