Skip to content

Conversation

@pyramation
Copy link
Contributor

fix: rename schema references in @pgpmjs/core

Summary

Updates hardcoded PostgreSQL schema names in the pgpm export functionality to match the schema rename in constructive-db PR #210:

  • collections_publicmetaschema_public (database metadata tables)
  • meta_publicservices_public (service tables like apis, sites, domains)

This is a breaking change that must be coordinated with the constructive-db rename.

Files changed:

  • pgpm/cli/src/commands/export.ts - SQL queries for database/schema selection
  • pgpm/core/src/export/export-meta.ts - Table config and SQL queries for metadata export
  • pgpm/core/src/export/export-migrations.ts - SQL queries and comments in migration export

Review & Testing Checklist for Human

  • CRITICAL: Verify this PR is merged and published AFTER constructive-db PR Fix/handle close #210 is deployed, or coordinate simultaneous deployment
  • Grep for any remaining collections_public or meta_public references in the pgpm packages that may have been missed
  • Verify the pg-ast file changes (version 1.30.2 → 1.30.4) are intentional and not accidental noise
  • Test pgpm export command against a database with the new schema names to verify queries work

Recommended test plan: Deploy constructive-db changes first, then run pgpm export against a test database to verify the export functionality works end-to-end with the new schema names.

Notes

  • Part of the massive schema rename effort documented in docs/plan/NAMING-PROPOSAL.md in constructive-db
  • This PR is a dependency for constructive-db PR Fix/handle close #210 to pass CI (introspection tests)

Link to Devin run: https://app.devin.ai/sessions/6b4b0a2f64084dfaa4a82c0cef42bc43
Requested by: Dan Lynch (@pyramation)

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration
Copy link
Contributor

Closing in favor of PR #551 (rename/develop consolidation branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants