Skip to content

Conversation

@pyramation
Copy link
Contributor

feat: rename schemas collections_public -> metaschema_public, meta_public -> services_public

Summary

Updates the @pgpmjs/core and @pgpmjs/cli packages to use the new schema naming convention:

  • collections_publicmetaschema_public
  • meta_publicservices_public

This change is required for compatibility with the schema rename in constructive-io/constructive-db (PR #210).

Files changed:

  • pgpm/core/src/export/export-meta.ts - Updated config and query strings
  • pgpm/core/src/export/export-migrations.ts - Updated query strings and comments
  • pgpm/cli/src/commands/export.ts - Updated query strings
  • pgpm/core/__tests__/export/export-flow.test.ts - Updated test fixtures
  • pgpm/core/__tests__/export/export-meta.test.ts - Updated test assertions

Review & Testing Checklist for Human

  • Verify coordination with constructive-db: This PR must be merged in coordination with constructive-io/constructive-db#210. The database schemas must be renamed before this tooling update is deployed.
  • Search for missed references: Run grep -r "collections_public\|meta_public" pgpm/ to verify no schema references were missed in source files
  • Test export command: Run pgpm export against a database with the new schema names (metaschema_public, services_public) to verify queries work correctly
  • Check for downstream consumers: Verify no other packages in this repo depend on the old schema names

Recommended test plan:

  1. Deploy constructive-db with the new schema names to a test database
  2. Run pgpm export and verify it successfully queries the renamed schemas
  3. Verify exported SQL files reference the correct schema names

Notes

This is a breaking change - the pgpm tooling will no longer work with databases using the old schema names (collections_public, meta_public).

Link to Devin run: https://app.devin.ai/sessions/6b4b0a2f64084dfaa4a82c0cef42bc43
Requested by: Dan Lynch (@pyramation)

…blic -> services_public

This change updates the @pgpmjs/core package to use the new schema names:
- collections_public -> metaschema_public
- meta_public -> services_public

This is required for compatibility with constructive-db schema rename.
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration
Copy link
Contributor

Closing in favor of PR #551 (rename/develop consolidation branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants