feat(cdn): add BUCKET_PROVIDER env var for explicit storage provider selection

[pyramation]

feat(cdn): add BUCKET_PROVIDER env var for explicit storage provider selection

Summary

Fixes an issue where isMinio was always true because minioEndpoint: 'http://localhost:9000' was hardcoded in pgpmDefaults. When deepmerge combined defaults with env vars, the default minioEndpoint persisted even when not explicitly set, causing S3 to be misconfigured in production.

This PR adds a BUCKET_PROVIDER env var (s3 | minio | gcs) as the single source of truth for provider selection. The provider is propagated through the entire upload chain:

pgpm/types → pgpm/env → s3-streamer → graphile-upload-plugin → graphile-settings → explorer

Key changes:

• New BucketProvider type and provider field in CDNOptions
• Default provider is 'minio' for local dev (preserves existing behavior)
• Setting BUCKET_PROVIDER=s3 in production correctly configures for S3
• Breaking: Removed IS_MINIO env var and hostname heuristics entirely
• Breaking: createS3Bucket now requires explicit { provider } options parameter

Updates since last revision

• Refactored to ensure process.env is only read in env packages (pgpm/env)
• createS3Bucket(client, bucket) → createS3Bucket(client, bucket, { provider })
• Removed all process.env.BUCKET_PROVIDER reads from s3-utils
• Provider must now be passed explicitly from getEnvOptions() at call sites
• Updated all tests to pass { provider: 'minio' } instead of setting env vars
• Replaced console.log/console.error with Logger in create-bucket.ts

Review & Testing Checklist for Human

• Breaking API change: createS3Bucket signature changed - verify no external callers exist outside this repo
• Check fallback logic in s3.ts: Line has opts.provider === 'minio' || (opts.provider === undefined && Boolean(opts.minioEndpoint)) - verify this backwards-compat fallback is intentional or should be removed
• Test S3 production config: Set BUCKET_PROVIDER=s3 and verify MinIO-specific config (endpoint, forcePathStyle) is NOT applied
• Test MinIO local dev: Verify BUCKET_PROVIDER=minio (or unset, which defaults to minio) works with local MinIO

Recommended test plan:

1. Run existing upload tests to verify no regression
2. Manually test file upload with BUCKET_PROVIDER=s3 against real S3 bucket
3. Manually test file upload with BUCKET_PROVIDER=minio against local MinIO
4. Grep for IS_MINIO and process.env.BUCKET_PROVIDER to verify cleanup is complete

Notes

• The BUCKET_PROVIDER env var is not validated at runtime - invalid values will be passed through as-is
• The pnpm-lock.yaml changes are mostly formatting; the only functional change is adding @pgpmjs/types as a dependency to graphile-upload-plugin
• Future work: Could add gcs (Google Cloud Storage) support using the same provider pattern

Link to Devin run: https://app.devin.ai/sessions/786904f315914f5c9d9c45e6707d7048
Requested by: Dan Lynch (@pyramation)

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring