wip: add bucket_provider

graphile/graphile-settings/src/index.ts

@@ -32,6 +32,7 @@ export const getGraphileSettings = (
     awsAccessKey: cdn.awsAccessKey!,
     awsSecretKey: cdn.awsSecretKey!,
     minioEndpoint: cdn.minioEndpoint,
+    provider: cdn.provider,
   });
 
   const resolveUpload = uploader.resolveUpload.bind(uploader);

graphile/graphile-upload-plugin/__tests__/plugin.test.ts

@@ -34,7 +34,9 @@ import gql from 'graphql-tag';
 const SCHEMA = process.env.SCHEMA ?? 'app_public';
 const sql = (f: string) => join(__dirname, '../sql', f);
 
-// Use defaults with optional overrides
+// Use defaults with optional overrides.
+// Defaults are MinIO‑style (provider: 'minio', localhost endpoint),
+// which is suitable for local/CI test environments.
 const config = getEnvOptions({
   cdn: {
     bucketName: 'test-upload-bucket'

graphile/graphile-upload-plugin/src/resolvers/upload.ts

@@ -7,6 +7,7 @@ export interface UploaderOptions {
   awsSecretKey: string;
   awsAccessKey: string;
   minioEndpoint?: string;
+  provider?: 's3' | 'minio' | string;
 }
 
 export class Uploader {
@@ -18,7 +19,8 @@ export class Uploader {
       awsRegion,
       awsSecretKey,
       awsAccessKey,
-      minioEndpoint
+      minioEndpoint,
+      provider
     } = this.opts;
 
     this.streamerInstance = new streamer({
@@ -27,6 +29,7 @@ export class Uploader {
       awsSecretKey,
       awsAccessKey,
       minioEndpoint,
+      provider
     });
   }
 

graphql/env/__fixtures__/env.keys.json

@@ -27,6 +27,7 @@
   "AWS_ACCESS_KEY_ID",
   "AWS_SECRET_KEY",
   "AWS_SECRET_ACCESS_KEY",
+  "BUCKET_PROVIDER",
   "MINIO_ENDPOINT",
   "DEPLOYMENT_USE_TX",
   "DEPLOYMENT_FAST",

graphql/explorer/src/resolvers/uploads.ts

@@ -9,6 +9,7 @@ interface UploaderOptions {
   awsSecretKey: string;
   awsAccessKey: string;
   minioEndpoint?: string;
+  provider?: 's3' | 'minio' | string;
 }
 
 interface Upload {
@@ -32,7 +33,8 @@ export class UploadHandler {
       awsRegion: options.awsRegion,
       awsSecretKey: options.awsSecretKey,
       awsAccessKey: options.awsAccessKey,
-      minioEndpoint: options.minioEndpoint
+      minioEndpoint: options.minioEndpoint,
+      provider: options.provider
     });
   }
 

pgpm/env/__fixtures__/env.keys.json

@@ -27,6 +27,7 @@
   "AWS_ACCESS_KEY_ID",
   "AWS_SECRET_KEY",
   "AWS_SECRET_ACCESS_KEY",
+  "BUCKET_PROVIDER",
   "MINIO_ENDPOINT",
   "DEPLOYMENT_USE_TX",
   "DEPLOYMENT_FAST",

pgpm/env/__tests__/__snapshots__/merge.test.ts.snap

@@ -8,6 +8,7 @@ exports[`getEnvOptions merges defaults, config, env, and overrides 1`] = `
     "awsSecretKey": "minioadmin",
     "bucketName": "test-bucket",
     "minioEndpoint": "http://localhost:9000",
+    "provider": "minio",
   },
   "db": {
     "connections": {

pgpm/env/src/env.ts

@@ -57,6 +57,7 @@ export const getEnvVars = (): PgpmOptions => {
     AWS_SECRET_KEY,
     AWS_SECRET_ACCESS_KEY,
     MINIO_ENDPOINT,
+    BUCKET_PROVIDER,
 
     DEPLOYMENT_USE_TX,
     DEPLOYMENT_FAST,
@@ -121,6 +122,7 @@ export const getEnvVars = (): PgpmOptions => {
       ...(PGDATABASE && { database: PGDATABASE }),
     },
     cdn: {
+      ...(BUCKET_PROVIDER && { provider: BUCKET_PROVIDER as any }),
       ...(BUCKET_NAME && { bucketName: BUCKET_NAME }),
       ...(AWS_REGION && { awsRegion: AWS_REGION }),
       ...((AWS_ACCESS_KEY || AWS_ACCESS_KEY_ID) && { awsAccessKey: AWS_ACCESS_KEY || AWS_ACCESS_KEY_ID }),

pgpm/types/src/pgpm.ts

@@ -110,6 +110,13 @@ export interface ServerOptions {
  * CDN and file storage configuration
  */
 export interface CDNOptions {
+    /**
+     * CDN / object storage provider.
+     * - 's3'    → AWS S3 (default)
+     * - 'minio' → MinIO / S3‑compatible endpoint
+     * - string  → reserved for future providers
+     */
+    provider?: 's3' | 'minio' | string;
     /** S3 bucket name for file storage */
     bucketName?: string;
     /** AWS region for S3 bucket */
@@ -241,6 +248,9 @@ export const pgpmDefaults: PgpmOptions = {
     strictAuth: false,
   },
   cdn: {
+    // Defaults are MinIO‑style for local/dev;
+    // production should override via BUCKET_PROVIDER=s3.
+    provider: 'minio',
     bucketName: 'test-bucket',
     awsRegion: 'us-east-1',
     awsAccessKey: 'minioadmin',

uploads/s3-streamer/__tests__/uploads.test.ts

@@ -9,6 +9,8 @@ import { getClient, Streamer, upload } from '../src';
 import type { AsyncUploadResult } from '../src/utils';
 
 // Use Constructive defaults with optional overrides
+// Defaults are MinIO‑style (provider: 'minio', localhost endpoint),
+// which is suitable for local/CI test environments.
 const config = getEnvOptions({
   cdn: {
     bucketName: 'test-bucket'

uploads/s3-streamer/src/s3.ts

@@ -5,10 +5,21 @@ interface S3Options {
   awsSecretKey: string;
   awsRegion: string;
   minioEndpoint?: string;
+  /**
+   * Object storage provider.
+   * - 's3'    → AWS S3 (default)
+   * - 'minio' → MinIO / S3‑compatible endpoint
+   * If omitted, presence of `minioEndpoint` will imply MinIO for
+   * backwards compatibility.
+   */
+  provider?: 's3' | 'minio' | string;
 }
 
 export default function getS3(opts: S3Options): S3Client {
-  const isMinio = Boolean(opts.minioEndpoint);
+  // Prefer explicit provider; fall back to endpoint for legacy callers
+  const isMinio =
+    opts.provider === 'minio' ||
+    (!opts.provider && Boolean(opts.minioEndpoint));
 
   const awsConfig: S3ClientConfig = {
     region: opts.awsRegion,

uploads/s3-streamer/src/streamer.ts

@@ -9,6 +9,7 @@ interface StreamerOptions {
   awsSecretKey: string;
   awsAccessKey: string;
   minioEndpoint?: string;
+  provider?: 's3' | 'minio' | string;
   defaultBucket: string;
 }
 
@@ -28,13 +29,15 @@ export class Streamer {
     awsSecretKey,
     awsAccessKey,
     minioEndpoint,
+    provider,
     defaultBucket
   }: StreamerOptions) {
     this.s3 = getS3({
       awsRegion,
       awsSecretKey,
       awsAccessKey,
-      minioEndpoint
+      minioEndpoint,
+      provider
     });
     this.defaultBucket = defaultBucket;
   }