Skip to content

1.2.3 version Bugfix: README example broken #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IgorChvyrov-sm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

1.2.3 version Bugfix: README example broken #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/conductor/client/workflow/task/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ def __init__(self,
cache_ttl_second: int = 0) -> Self:
self.task_reference_name = task_reference_name
self.task_type = task_type
self.task_name = task_name if task_name is not None else task_type.value
Copy link
Contributor

@v1r3n v1r3n Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this needed for the workflow as code?

Copy link
Contributor Author

@IgorChvyrov-sm IgorChvyrov-sm Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task_name is not used anywhere, what do you mean by workflow as code ?

self.name = task_name or task_reference_name
self.description = description
self.optional = optional
self.input_parameters = input_parameters if input_parameters is not None else {}
self.cache_key = cache_key
self.cache_ttl_second = cache_ttl_second
self.input_parameters = input_parameters
self._cache_key = cache_key
self._cache_ttl_second = cache_ttl_second
self._expression = None
self._evaluator_type = None

Expand Down Expand Up @@ -175,7 +175,7 @@ def input(self, json_path: Optional[str] = None, key: Optional[str] = None, valu
else:
return "${" + f"{self.task_reference_name}.input.{json_path}" + "}"

def __getattribute__(self, __name: str, /) -> Any:
def __getattribute__(self, __name: str) -> Any:
try:
val = super().__getattribute__(__name)
return val
Expand Down