Skip to content

Ignore api requests for mocked ids in useCoreApi #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gciotola wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Ignore api requests for mocked ids in useCoreApi #961

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f327c69
fix: ignore api requests for mocked ids in `useCoreApi`
gciotola Jun 30, 2025
30ac71c
fix: remove check for action retrieve when identifying mocked id
gciotola Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion packages/app-elements/src/providers/CoreSdkProvider/useCoreApi.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { isMockedId } from '#helpers/mocks'
import { type ResourceEndpoint } from '#helpers/resources'
import { useTokenProvider } from '#providers/TokenProvider'
import type { CommerceLayerClient } from '@commercelayer/sdk'
import { isString } from 'lodash-es'
import { useCallback } from 'react'
import useSWR, {
type Fetcher,
Expand Down Expand Up @@ -70,8 +72,24 @@ export function useCoreApi<
)

return useSWR(
args !== null ? [resource, action, args, mode] : null,
args == null || isArgsForMockedId(args)
? null
: [resource, action, args, mode],
fetcher,
config ?? {}
)
}

/**
* Check if the useCoreApi args contain a request for a mocked resource id.
* This is used to determine if the request should be ignored (when is for a mocked id).
*/
function isArgsForMockedId(args: any): boolean {
return (
args != null &&
Array.isArray(args) &&
args.length > 0 &&
isString(args[0]) &&
isMockedId(args[0])
)
}