-
Notifications
You must be signed in to change notification settings - Fork 578
fix:fixing polygon testnet details #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🟡 Heimdall Review Status
|
| rpc_urls={ | ||
| "default": { | ||
| "http": ["https://rpc.ankr.com/polygon_mumbai"], | ||
| "http": ["https://polygon-amoy-bor-rpc.publicnode.com"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "http": ["https://polygon-amoy-bor-rpc.publicnode.com"], | |
| "http": ["https://rpc-amoy.polygon.technology"], |
| "url": "https://mumbai.polygonscan.com", | ||
| "api_url": "https://api-testnet.polygonscan.com/api", | ||
| "url": "https://amoy.polygonscan.com/", | ||
| "api_url": "https://api.etherscan.io/v2/api", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "api_url": "https://api.etherscan.io/v2/api", | |
| "api_url": "https://api-amoy.polygonscan.com/api", |
| "name": "PolygonScan", | ||
| "url": "https://polygonscan.com", | ||
| "api_url": "https://api.polygonscan.com/api", | ||
| "api_url": "https://api.etherscan.io/v2/api", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert
|
Hi @sanketsaagar, thanks for the update! Could you please align url/apiUrl with what is used in viem: https://github.com/wevm/viem/blob/main/src/chains/definitions/polygonAmoy.ts? |
…itions.py Co-authored-by: phdargen <pdargent@icloud.com>
|
Thanks for the update @sanketsaagar, please also change the api_urls as mentioned above |
Hey @phdargen , As of August 15th, 2025, the legacy Etherscan API V1 endpoints have been deprecated in favor of the new Etherscan API V2, which introduces a unified multichain experience across 60+ supported networks. That means we now have to use h So just to give you an example for polygon it should look like And for Amoy it should look like You can read more here. I will be raising PR at viem as well to update the details. Thanks for sharing that with me. |
Oh I see, thanks for the info @sanketsaagar! |
|
Hi @sanketsaagar, sorry just noticed the unit tests are failing. Could you please also update polygon-mumbai in this file: python/coinbase-agentkit/coinbase_agentkit/network/init.py |
|
Please also add a changelog as described here: https://github.com/coinbase/agentkit/blob/main/CONTRIBUTING-PYTHON.md#changelog |
|
Thanks for the update @sanketsaagar, seems something went wrong with the changelog as it was added to the repository root. Could you please remove and then run and run This should create the changelogs in the correct file locations |
|
Review Error for hoppllo94 @ 2025-12-25 06:41:08 UTC |
Description