Skip to content

Properly escape search queries in URLs #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codesalatdev merged 1 commit into from
Feb 27, 2025
Merged

Properly escape search queries in URLs #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python_picnic_api2/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import re
from hashlib import md5
from urllib.parse import quote

import typing_extensions

Expand Down Expand Up @@ -95,7 +96,7 @@ def get_user(self):
return self._get("/user")

def search(self, term: str):
path = f"/pages/search-page-results?search_term={term}"
path = f"/pages/search-page-results?search_term={quote(term)}"
raw_results = self._get(path, add_picnic_headers=True)
return _extract_search_results(raw_results)

Expand Down
8 changes: 8 additions & 0 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,14 @@ def test_search(self):
headers=PICNIC_HEADERS,
)

def test_search_encoding(self):
self.client.search("Gut&Günstig H-Milch")
self.session_mock().get.assert_called_with(
self.expected_base_url
+ "/pages/search-page-results?search_term=Gut%26G%C3%BCnstig%20H-Milch",
headers=PICNIC_HEADERS,
)

def test_get_cart(self):
self.client.get_cart()
self.session_mock().get.assert_called_with(
Expand Down