Skip to content

Conversation

@rowansmithau
Copy link
Contributor

Description

When using the SAML auth method with Vault and authenticating via CLI it is required to use the enterprise version of the binary, as SAML support is not built into the non enterprise version of the CLI. This PR adds an optional enterprise variable to support this.

@matifali can you let me know the appropriate tag command to run to release this once approved, please?

Type of Change

  • New module
  • New template
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/coder/modules/vault-cli
New version: v1.1.0
Breaking change: [ ] Yes [x] No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun fmt)
  • Changes tested locally

Related Issues

None

@rowansmithau rowansmithau requested a review from matifali December 5, 2025 01:57
@rowansmithau rowansmithau self-assigned this Dec 5, 2025
@rowansmithau rowansmithau added the version:minor Add to PRs requiring a minor version upgrade label Dec 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

❌ Version Bump Validation Failed

Bump Type: minor

Module versions need to be updated but haven't been bumped yet.

Required Actions:

  1. Run the version bump script locally: ./.github/scripts/version-bump.sh minor
  2. Commit the changes: git add . && git commit -m "chore: bump module versions (minor)"
  3. Push the changes: git push

Script Output:

🔍 Detecting modified modules...
Found modules:
registry/coder/modules/vault-cli

📦 Processing: coder/vault-cli
No git tag found, but README shows version: 1.1.0
Current version: 1.1.0
New version: 1.2.0
Updating version references for coder/vault-cli in registry/coder/modules/vault-cli/README.md

🔧 Running formatter to ensure consistent formatting...

📋 Summary:
Bump Type: minor

Modules Updated:

- coder/vault-cli: v1.1.0 → v1.2.0

READMEs Updated:

- coder/vault-cli

⚠️  Modules Without Git Tags:

- coder/vault-cli (README: v1.1.0)
These modules were versioned based on README content. Consider creating proper release tags after merging.

✅ Version bump completed successfully!
📝 README files have been updated with new versions.

Next steps:
1. Review the changes: git diff
2. Commit the changes: git add . && git commit -m 'chore: bump module versions (minor)'
3. Push the changes: git push

Please update the module versions and push the changes to continue.

@rowansmithau
Copy link
Contributor Author

it looks like 1.0.0 is in the registry, not 1.1.0 is the check claims?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:minor Add to PRs requiring a minor version upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant