⚡️ Speed up method PdfPages.infodict by 62%
#234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 62% (0.62x) speedup for
PdfPages.infodictinlib/matplotlib/backends/backend_pdf.py⏱️ Runtime :
1.23 microseconds→759 nanoseconds(best of5runs)📝 Explanation and details
The optimization eliminates unnecessary method calls and attribute lookups by inlining the
_ensure_file()logic directly intoinfodict().Key Changes:
infodict()method now directly checksif self._file is not Noneand handles file creation inline, eliminating the overhead of calling_ensure_file()infoDictWhy it's faster:
self._filetwice (once in_ensure_file(), once for the return), while the optimized version accesses it only once per execution path.Performance characteristics:
_filealready existsinfodict()is called repeatedly after the first file initializationThis micro-optimization targets a common access pattern in PDF generation where metadata dictionaries are frequently queried, making the cumulative performance gain significant over many operations.
✅ Correctness verification report:
🌀 Generated Regression Tests and Runtime
To edit these changes
git checkout codeflash/optimize-PdfPages.infodict-miypfu2qand push.