Skip to content

test: standardise mocks folder names #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
poltorak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: standardise mocks folder names #1209

poltorak wants to merge 1 commit into from
+8 −8

Conversation

@poltorak
Copy link
Collaborator

@poltorak poltorak commented Jan 9, 2026 •
edited
Loading

Covers #1168

Standardize Folder Naming

Scope: Renamed mock → mocks folders for consistency
Files affected: 8 files across examples and nx-plugin packages
Impact: Pure renaming with corresponding import path updates

Files changed:

examples/plugins/src/lighthouse/mock/ → mocks/
packages/nx-plugin/mock/ → mocks/
Updated import references in test files and documentation

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 nx-plugin 🛠️ tooling labels Jan 9, 2026
@nx-cloud
Copy link

nx-cloud bot commented Jan 9, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 961e2d8

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 25s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 25s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1m 15s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-12 08:41:34 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 9, 2026 •
edited
Loading

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1209

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1209

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1209

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1209

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1209

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1209

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1209

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1209

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1209

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1209

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1209

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1209

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1209

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1209

commit: 961e2d8

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit b3d3d2f with previous commit 7d3681c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 37 🔴 27 ↓ −9.8
Code coverage 🟢 91 🟢 91 ↑ +0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Documentation 🔴 34 🔴 34 ↓ −0.1
Code style 🟢 99 🟢 99 –
Security 🟡 51 🟡 51 –
Updates 🟡 78 🟡 78 –
Type Safety 🟡 67 🟡 67 –
Miscellaneous 🟡 67 🟡 67 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟢 92 🟢 92 –
👍 1 group improved, 👎 2 groups regressed, 👍 1 audit improved, 👎 6 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 37 🔴 27 ↓ −9.8
Code coverage Code coverage metrics 🟢 91 🟢 91 ↑ +0.1
JSDocs coverage Documentation coverage 🔴 34 🔴 34 ↓ −0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 5.9 s 🟥 11.2 s ↑ +91.6 %
Lighthouse First Contentful Paint 🟥 3.0 s 🟥 4.2 s ↑ +40.6 %
Lighthouse Total Blocking Time 🟥 1,990 ms 🟥 7,840 ms ↑ +293 %
Lighthouse Time to Interactive 🟥 13.0 s 🟥 17.2 s ↑ +32.3 %
Code coverage Branch coverage 🟨 87.3 % 🟨 87.4 % ↑ +0.1 %
Code coverage Line coverage 🟨 86.2 % 🟨 86.2 % ↓ −0.1 %
Code coverage Function coverage 🟩 93.4 % 🟩 93.4 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 8.9 s 🟥 22.0 s ↑ +146.4 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,113 KiB 🟩 Total size was 2,124 KiB ↑ +0.5 %
Lighthouse JavaScript execution time 🟥 4.4 s 🟥 10.8 s ↑ +144.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +32.3 %
Lighthouse Largest Contentful Paint 🟥 11.4 s 🟥 15.0 s ↑ +31.5 %
Lighthouse Max Potential First Input Delay 🟥 1,040 ms 🟥 3,960 ms ↑ +279.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 95 KiB 🟥 Potential savings of 95 KiB ↓ −25 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 200 KiB 🟥 Potential savings of 224 KiB ↑ +14.2 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 103 KiB 🟥 Potential savings of 107 KiB ↑ +33.3 %
Lighthouse Initial server response time was short 🟩 Root document took 400 ms 🟩 Root document took 550 ms ↑ +37.5 %
Lighthouse Server Backend Latencies 🟩 1,050 ms 🟩 1,130 ms ↑ +7.2 %
Lighthouse Network Round Trip Times 🟩 0 ms 🟩 70 ms ↑ +1380.6 %

659 other audits are unchanged.

@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch 2 times, most recently from 777ce08 to 4fb2ca7 Compare January 9, 2026 12:01
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit b3d3d2f with previous commit 7d3681c.

💼 Project nx-plugin

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 89 🟡 89 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved, 👎 2 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 89 🟡 89 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟨 76.3 % 🟨 77 % ↑ +1 %
Code coverage Line coverage 🟨 84.8 % 🟨 84.5 % ↓ −0.4 %
Code coverage Function coverage 🟩 96.4 % 🟩 96.3 % ↓ −0.1 %

445 other audits are unchanged.

💼 Project utils

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 36 🔴 36 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 36 🔴 36 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

All of 444 audits are unchanged.

12 other projects are unchanged.

@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch from 4fb2ca7 to cdb82a1 Compare January 9, 2026 12:37
BioPhoton
BioPhoton requested changes Jan 9, 2026
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split mock folder renaming and setup script refactoring into 2 PR's pls.
I have some more comments on the test setup that would delay the mock renaming part.

Also i already renamed your PR to: "test: standardise mocks folder names" so I can add my feedback related to the renaming here.

@BioPhoton BioPhoton changed the title Refactor: cosmetic cleanup and changes test: standardise mocks folder names Jan 9, 2026
@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch from cdb82a1 to ffbe58d Compare January 12, 2026 08:17
@poltorak
Copy link
Collaborator Author

poltorak commented Jan 12, 2026

Could you split mock folder renaming and setup script refactoring into 2 PR's pls. I have some more comments on the test setup that would delay the mock renaming part.

Done, current PR contains only mocks rename

@poltorak poltorak force-pushed the refactor/cosmetic-cleanup-and-changes branch from ffbe58d to 961e2d8 Compare January 12, 2026 08:25
@poltorak poltorak marked this pull request as ready for review January 12, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BioPhoton BioPhoton BioPhoton requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@poltorak poltorak

Labels

🧩 nx-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@poltorak @BioPhoton