-
Notifications
You must be signed in to change notification settings - Fork 7
Better match #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AbdelrhmanBassiouny
merged 56 commits into
code-iai:main
from
AbdelrhmanBassiouny:better_match
Dec 2, 2025
Merged
Better match #52
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
c63854b
[EQL] match automatically determines which comparator type to use, wh…
AbdelrhmanBassiouny dc6103c
[EQL] set_of can use match instances as its selectables.
AbdelrhmanBassiouny 9df3ea4
[EQLMatch] match does not require kwargs.
AbdelrhmanBassiouny 191df0a
[EQLMatch] selectables.
AbdelrhmanBassiouny 4de351f
[EQLMatch] match can return a set_of.
AbdelrhmanBassiouny d0581d1
[EQLMatch] match can return a set_of.
AbdelrhmanBassiouny cac9883
[EQLMatch] in progress selecting literals.
AbdelrhmanBassiouny d0ec235
[EQL] select seems to work.
AbdelrhmanBassiouny 7e5af65
[EQLMatch] cleaning.
AbdelrhmanBassiouny 0a9a16c
[EQLMatch] only return entity() with the parent match variable select…
AbdelrhmanBassiouny d430882
[EQLMatch] cleaning.
AbdelrhmanBassiouny 16503d5
[EQLMatch] cleaning.
AbdelrhmanBassiouny bb00cf5
[EQLMatch] doc.
AbdelrhmanBassiouny 3f59ad7
[EQLMatch] fix type hints of match return
AbdelrhmanBassiouny ad9fe80
[EQLMatch] test match.
AbdelrhmanBassiouny bd59c08
[EQLMatch] test match any
AbdelrhmanBassiouny ae2ebec
[EQLMatch] cleaning and docs.
AbdelrhmanBassiouny 7bcd501
[EQLMatch] more tests, cleaning.
AbdelrhmanBassiouny 993b245
[EQLMatch] back to match_any, and select_any.
AbdelrhmanBassiouny 0426954
Merge remote-tracking branch 'code_iai/main' into better_match
AbdelrhmanBassiouny 67a7522
[EQLMatch] restructuring, created match.py, and quantify_entity.py.
AbdelrhmanBassiouny c321957
[EQLMatch] update docs.
AbdelrhmanBassiouny db9f2e5
[EQLMatch] better way of finding if variable values are iterable.
AbdelrhmanBassiouny 2a3ee59
[EQLMatch] more efficient exists and comparator.
AbdelrhmanBassiouny c613396
[EQLMatch] doc update
AbdelrhmanBassiouny 95e1955
[EQLMatch] doc update
AbdelrhmanBassiouny 7ea4804
[EQL] updated match logic, need to fix existential and universal cond…
AbdelrhmanBassiouny d627aaa
[EQL] universal match doesn't work.
AbdelrhmanBassiouny 6157830
[EQL] Symbol doc update.
AbdelrhmanBassiouny b261b8e
[EQL] fixed match all.
AbdelrhmanBassiouny cead85e
[EQL] fixed match notebook.
AbdelrhmanBassiouny e948639
[EQL] fixed match notebook.
AbdelrhmanBassiouny 84f8a87
[EQL] fix method doc.
AbdelrhmanBassiouny 8c5365f
[EQL] review changes.
AbdelrhmanBassiouny 7686f7f
[EQL] review changes.
AbdelrhmanBassiouny f0c159d
[EQL] review changes.
AbdelrhmanBassiouny e5f6838
[EQL] Created AttributeAssignment class.
AbdelrhmanBassiouny 11358b3
[EQL] Class doc.
AbdelrhmanBassiouny 1fda110
[EQLMatch] fix type hints.
AbdelrhmanBassiouny 6d9582e
[EQLMatch] doc fix.
AbdelrhmanBassiouny 5387298
Merge remote-tracking branch 'code_iai/main' into better_match
AbdelrhmanBassiouny 144ff40
[EQLMatch] fix selection.
AbdelrhmanBassiouny 51981cd
Merge remote-tracking branch 'code_iai/main' into better_match
AbdelrhmanBassiouny 3a3e138
[EQLMatch] us normal in.
AbdelrhmanBassiouny a6f2415
Merge remote-tracking branch 'code_iai/main' into better_match
AbdelrhmanBassiouny 2f72c1d
[EQLMatch] compare variables using hash to avoid symbolic comparison.
AbdelrhmanBassiouny 591faa0
[EQLMatch] compare variables using hash to avoid symbolic comparison.
AbdelrhmanBassiouny b5b9418
[EQLFeatures] review changes.
AbdelrhmanBassiouny 32d029a
[EQLMatch] removed unused method.
AbdelrhmanBassiouny d620f52
[EQLMatch] review changes.
AbdelrhmanBassiouny bf2e0c9
[EQLMatch] review changes.
AbdelrhmanBassiouny d497b41
[EQLMatch] fix None instances problem.
AbdelrhmanBassiouny c63d037
removed is_universal_match and is_existential_match
LucaKro 5be0136
Merge pull request #2 from LucaKro/better_match
AbdelrhmanBassiouny 31ea32d
Merge remote-tracking branch 'code_iai/main' into better_match
AbdelrhmanBassiouny a78c6d4
[EQLMatch] fix and cleaning
AbdelrhmanBassiouny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -471,7 +471,7 @@ def get_wrapped_class(self, clazz: Type) -> Optional[WrappedClass]: | |
| except KeyError: | ||
| raise ClassIsUnMappedInClassDiagram(clazz) | ||
|
|
||
| def add_node(self, clazz: WrappedClass): | ||
| def add_node(self, clazz: Union[Type, WrappedClass]): | ||
| """ | ||
| Adds a new node to the dependency graph for the specified wrapped class. | ||
|
|
||
|
|
@@ -481,6 +481,12 @@ class to the wrapped class. | |
|
|
||
| :param clazz: The wrapped class object to be added to the dependency graph. | ||
| """ | ||
| try: | ||
| clazz = self.get_wrapped_class(clazz) | ||
| except ClassIsUnMappedInClassDiagram: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. very weird way of checking if the class already belings to the class diagram
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. how else would it be? |
||
| clazz = WrappedClass(clazz) | ||
| if clazz.index is not None: | ||
| return | ||
| clazz.index = self._dependency_graph.add_node(clazz) | ||
| clazz._class_diagram = self | ||
| self._cls_wrapped_cls_map[clazz.clazz] = clazz | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.