Skip to content

confirm support for CockroachDB 26.1 #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
timgraham wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

confirm support for CockroachDB 26.1 #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ jobs:
- crdb-version: v25.4.0
use_server_side_binding: server_side_binding
# Uncomment to enable testing of CockroachDB nightly.
#- crdb-version: LATEST
#- crdb-version: LATEST
# use_psycopg2: psycopg2
#- crdb-version: LATEST
# use_server_side_binding: server_side_binding
- crdb-version: LATEST
- crdb-version: LATEST
use_psycopg2: psycopg2
- crdb-version: LATEST
use_server_side_binding: server_side_binding
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v4
Expand Down
6 changes: 5 additions & 1 deletion django_cockroachdb/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@ def is_cockroachdb_25_2(self):
def is_cockroachdb_25_4(self):
return self.connection.cockroachdb_version >= (25, 4)

@cached_property
def is_cockroachdb_26_1(self):
return self.connection.cockroachdb_version >= (26, 1)

@cached_property
def django_test_expected_failures(self):
expected_failures = super().django_test_expected_failures
Expand Down Expand Up @@ -360,7 +364,7 @@ def django_test_skips(self):
'schema.tests.SchemaTests.test_alter_field_type_and_db_collation',
},
})
if self.is_cockroachdb_25_4:
if self.is_cockroachdb_25_4 and not self.is_cockroachdb_26_1:
skips.update({
# Error truncating hundreds of tables:
# https://github.com/cockroachdb/cockroach/issues/156682
Expand Down