feat: allow using an array of selectors for selection functions

[kai-gitt]

No description provided.

[coderabbitai]

Walkthrough

The changes update the method signatures in the Component class within src/Component.ts. The select, selectAll, closest, and is methods now accept a variable number of string arguments using the rest parameter syntax (...selectors: string[]) rather than a single string. Inside the method bodies, the selectors are concatenated into a single string with commas separating them. This modification allows the use of multiple CSS selectors when querying the DOM, while the return types of these methods remain unchanged.

Possibly related PRs

• Add select and selectAll shorthands #12: Introduced the original single-selector implementations for select and selectAll, which are now being extended for multi-selector support.
• feat: add .is() on components #68: Addressed the introduction of the is method for a single selector, serving as a precursor to the current multi-selector update.

Suggested reviewers

• zefir-git

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 4

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8994eb1 and af55998.

📒 Files selected for processing (1)

• src/Component.ts (4 hunks)

🔇 Additional comments (1)

src/Component.ts (1)

63-99:

Details

❓ Verification inconclusive

Great feature addition with consistent implementation.

All four methods (select, selectAll, closest, and is) have been consistently updated to support multiple selectors, which is a valuable usability improvement. The implementation is correct and aligns with CSS selector group syntax.

While not critical, consider adding tests to verify both backward compatibility (single selector) and the new functionality (multiple selectors). This would help ensure the feature works as expected across various use cases.

---

🏁 Script executed:

#!/bin/bash
# Check if there are any existing tests for these methods
grep -r "select(" --include="*.test.ts" --include="*.spec.ts" .
grep -r "selectAll(" --include="*.test.ts" --include="*.spec.ts" .
grep -r "closest(" --include="*.test.ts" --include="*.spec.ts" .
grep -r "is(" --include="*.test.ts" --include="*.spec.ts" .

Length of output: 263

---

Subject: Verification of Test Coverage for Multi-Selector Methods

The updated implementations in src/Component.ts (lines 63–99) for the select, selectAll, closest, and is methods correctly support multiple selectors and adhere to CSS group selector conventions. However, our search did not reveal any test cases for these methods in the repository. Although this isn’t critical, it would be beneficial to add tests that confirm both the backward compatibility (using a single selector) and the new multi-selector functionality across various scenarios.

• Implementation: Methods are consistently updated and correctly map to CSS selector behaviours.
• Test Coverage: No test cases were located in files matching *.test.ts/*.spec.ts. Please ensure tests are added to cover:
  • Single selector queries.
  • Multiple selector queries.
  • Edge cases where no elements are found.

Please consider adding these tests to guarantee the feature works as expected.