Increase check timeout for "crashing" test #1792
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* default health check interval is 30 seconds and default health check timeout is 60 seconds, so the assertion can miss the moment when the app instance is reported as "CRASHED" * also decrease check interval from 5 to 15 seconds
jochenehret
changed the title
jochenehret
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
The "crashing" test suite often fails because one of the app instances is still reported as "STARTING". The default health check interval is 30 seconds and the default health check timeout is 60 seconds, so the assertion can miss the moment when the app instance is reported as "CRASHED". Increasing the check timeout to 90 seconds should fix that. Also decrease check interval from 5 to 15 seconds.
Please provide contextual information.
This test fails quite often, e.g.:
https://concourse.wg-ard.ci.cloudfoundry.org/teams/main/pipelines/noble-stemcell-validation/jobs/run-cats/builds/311
What version of cf-deployment have you run this cf-acceptance-test change against?
v54.0.0
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
How many more (or fewer) seconds of runtime will this change introduce to CATs?
At most 30 seconds.
What is the level of urgency for publishing this change?