Use System.Text.Json instead of Newtonsoft.Json #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have changed the JSON implementation from
Newtonsoft.JsontoSystem.Text.Json.We know this is a big one.
Why do we want to change the JSON serializer?
Newtonsoft.Jsonis no longer state-of-the-art..NET 5and ongoing have its own Json serializer implementation.NullValueHandling = NullValueHandling.Ignore, etc.). Said option is now set in DefaultJsonSerializerOptions.cs.All testes are passing. The hash sum of one test (URL) had to be changed because an unneeded field that was there beforehand is no longer present in the resulting JSON.
A few fields had to be changed from
dynamictoobject. But the resulting JSON is the same.System.Text.Jsondoes not supportdynamic.What I am not 100% sure is if it works correctly is the
[JsonExtensionData]tag.Could you please provide some example data for the
Optionsfield forCaptureWebsiteCreateRequest, so I can compare the resulting Jsons ofNewtonsoftandSystem.Text.Json? Thank you.Implements #8.