Fix/dsc ingress annotation #952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmon33
force-pushed
the
fix/dsc-ingress-annotation
branch
from
9600dcc to
2a24125
Compare
iliesmrf
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro:
Quel est le comportement actuel ?
Le role socle-config, lorsqu'il effectue le rendu du template dsc.yaml, supprime toutes les annotations de la dsc, au lieu de supprimer uniquement les annotations qui se trouvent sous metadata.
Il en résulte qu'il supprime aussi dans ce fichier les annotations éventuelles de la partie ingress, ce que nous souhaitons éviter.
Quel est le nouveau comportement ?
Nous corrigeons le point en effectuant une supression préalable de la partie metadata de la représentation YAML qui sera écrite dans le fichier dsc.yaml, avant de la reconstruire avec les metadatas souhaitées (annotation "socleVersion" et nom de la dsc), de sorte que le reste des éventuelles annotations du fichier ne soit pas impacté.
Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Comportement testé et validé dans un cluster de test.