test(playwright): ⚗️ improve integration tests #1805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falltrades
force-pushed
the
playwright/integration-test-console
branch
7 times, most recently
from
1fec84e to
c5fd72f
Compare
Falltrades
force-pushed
the
playwright/integration-test-console
branch
from
c5fd72f to
947f0bd
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
Falltrades
force-pushed
the
playwright/integration-test-console
branch
from
947f0bd to
6f0b153
Compare
StephaneTrebel
approved these changes
Dec 11, 2025
Collaborator
StephaneTrebel
left a comment
StephaneTrebel
left a comment
There was a problem hiding this comment.
C'est beau. LGTM
Collaborator
There was a problem hiding this comment.
praise: Nickel 👍 Faudra dans le turfu qu'on source un fichier .env quelconque pour éviter la tartine d'export mais c'est un très bon début, et documenté 👏
| .fill(`${faker.internet.url({ appendSlash: true })}myrepository.git`) | ||
| } | ||
| if (infraRepo) { | ||
| await page.getByText('Dépôt contenant du code d\'').click() |
Collaborator
There was a problem hiding this comment.
thought: *soupir*, ça manque cruellement de data-testid et de id un peu partout…
Falltrades
force-pushed
the
playwright/integration-test-console
branch
from
6f0b153 to
b07e1b5
Compare
Falltrades
force-pushed
the
playwright/integration-test-console
branch
from
b07e1b5 to
61347e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro: cloud-pi-native/socle#611
Quel est le comportement actuel ?
We have some tests that we could improve.
Quel est le nouveau comportement ?
Cette PR introduit-elle un breaking change ?
No.
Autres informations
No.