Skip to content

fix: 🐛 gitlab mirror access token generation #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Falltrades merged 2 commits into from
Dec 8, 2025
Merged

fix: 🐛 gitlab mirror access token generation #1802

Falltrades merged 2 commits into from
Dec 8, 2025

Conversation

@Falltrades
Copy link
Contributor

@Falltrades Falltrades commented Dec 4, 2025 •
edited
Loading

Issues liées

Issues numéro:

Quel est le comportement actuel ?

  • We do not test the validity of the Gitlab access token. This brings troubles when:
    • Someone manually deleted the token in Gitlab.
    • Gitlab token expires after 1 year.
  • We do not compare secrets properly. This made the comparison always giving a true result, hence new generation of Vault secret is written even though nothing changes everytime users are reprovisioning their project.

Quel est le nouveau comportement ?

Fix all the above.

Cette PR introduit-elle un breaking change ?

No.

Autres informations

It remains GIT_MIRROR_TOKEN which got regenerated everytime users are reprovisioning their project. But this requires a more thorough investigation in order to refactor.

@Falltrades Falltrades self-assigned this Dec 4, 2025
@Falltrades Falltrades added the preview Deploy preview app with Argo-cd label Dec 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025 •
edited
Loading

🤖 Hey !

A preview of the application is available at : https://console-pr-1802.sdid-hp.cpin.numerique-interieur.com

Please be patient, deployment may take a few minutes.

@Falltrades Falltrades marked this pull request as ready for review December 4, 2025 14:51
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025 •
edited
Loading

🤖 Hey !

The @cpn-console/gitlab-plugin (v3.3.1) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025 •
edited
Loading

🤖 Hey !

The security scan report for the current pull request is available here.

@Falltrades Falltrades force-pushed the fix/gitlab-mirror-access-token-generation branch 9 times, most recently from b2018aa to b4cb778 Compare December 5, 2025 10:45
@Falltrades Falltrades added this to the MCO milestone Dec 5, 2025
@Falltrades Falltrades force-pushed the fix/gitlab-mirror-access-token-generation branch from b4cb778 to 10e8e66 Compare December 5, 2025 11:05
mathieulaude
mathieulaude reviewed Dec 5, 2025
View reviewed changes
mathieulaude
mathieulaude reviewed Dec 5, 2025
View reviewed changes
mathieulaude
mathieulaude reviewed Dec 5, 2025
View reviewed changes
@Falltrades Falltrades force-pushed the fix/gitlab-mirror-access-token-generation branch 4 times, most recently from 2199807 to cbddb77 Compare December 5, 2025 13:33
@Falltrades Falltrades force-pushed the fix/gitlab-mirror-access-token-generation branch from cbddb77 to fde6441 Compare December 5, 2025 13:52
@Falltrades Falltrades force-pushed the fix/gitlab-mirror-access-token-generation branch from fde6441 to 039f8b8 Compare December 5, 2025 14:10
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025 •
edited
Loading

🤖 Hey !

The @cpn-console/shared (v1.3.0) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@Falltrades Falltrades force-pushed the fix/gitlab-mirror-access-token-generation branch from 039f8b8 to 2f02794 Compare December 5, 2025 14:37
mathieulaude
mathieulaude reviewed Dec 5, 2025
View reviewed changes
StephaneTrebel
StephaneTrebel requested changes Dec 5, 2025
View reviewed changes
mathieulaude
mathieulaude requested changes Dec 5, 2025
View reviewed changes
Copy link
Collaborator

@mathieulaude mathieulaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ajouter des TU sur shallowEqual

@Falltrades Falltrades force-pushed the fix/gitlab-mirror-access-token-generation branch from 2f02794 to a033403 Compare December 5, 2025 15:39
@cloud-pi-native-sonarqube
Copy link

cloud-pi-native-sonarqube bot commented Dec 5, 2025

Passed Quality Gate passed

Issues

Measures

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube

StephaneTrebel
StephaneTrebel approved these changes Dec 8, 2025
View reviewed changes
Copy link
Collaborator

@StephaneTrebel StephaneTrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooo 🚀

@Falltrades Falltrades merged commit a4a3e0e into main Dec 8, 2025
34 checks passed
@Falltrades Falltrades deleted the fix/gitlab-mirror-access-token-generation branch December 8, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephaneTrebel StephaneTrebel StephaneTrebel approved these changes

@mathieulaude mathieulaude mathieulaude approved these changes

@iliesmrf iliesmrf Awaiting requested review from iliesmrf

Assignees

@Falltrades Falltrades

Labels

built preview Deploy preview app with Argo-cd

Projects

None yet

Milestone

MCO

Development

Successfully merging this pull request may close these issues.

4 participants

@Falltrades @StephaneTrebel @mathieulaude