Skip to content

Playwright/integration test console #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Falltrades merged 1 commit into from
Dec 3, 2025
Merged

Playwright/integration test console #1752

Falltrades merged 1 commit into from
Dec 3, 2025

Conversation

@Falltrades
Copy link
Contributor

@Falltrades Falltrades commented Oct 13, 2025 •
edited
Loading

Issues liées

Issues numéro: cloud-pi-native/socle#611

Quel est le comportement actuel ?

We don't have integration tests for our Console.

Quel est le nouveau comportement ?

Add integrations tests for Console.

Cette PR introduit-elle un breaking change ?

No.

Autres informations

No.

@Falltrades Falltrades force-pushed the playwright/integration-test-console branch from 08875ab to 980f218 Compare October 13, 2025 19:03
@Falltrades Falltrades added this to the Testing - QA milestone Oct 13, 2025
@Falltrades Falltrades added the CI/CD CI/CD stuffs label Oct 13, 2025
@Falltrades Falltrades self-assigned this Oct 13, 2025
@Falltrades Falltrades force-pushed the playwright/integration-test-console branch 2 times, most recently from 388298f to 9f8d5a7 Compare October 17, 2025 08:44
@Falltrades Falltrades changed the base branch from develop-old to main October 17, 2025 12:58
@Falltrades Falltrades force-pushed the playwright/integration-test-console branch 2 times, most recently from 9d8a95c to e31501b Compare October 20, 2025 14:49
@Falltrades Falltrades force-pushed the playwright/integration-test-console branch from e31501b to 2184de6 Compare October 26, 2025 12:38
@Falltrades Falltrades force-pushed the playwright/integration-test-console branch 4 times, most recently from f801dfe to aadf71d Compare November 24, 2025 13:44
@Falltrades Falltrades force-pushed the playwright/integration-test-console branch 3 times, most recently from b7aba27 to f60b1ea Compare November 26, 2025 09:29
@Falltrades Falltrades marked this pull request as ready for review November 26, 2025 09:29
@github-actions github-actions bot added the built label Nov 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025 •
edited
Loading

🤖 Hey !

The security scan report for the current pull request is available here.

@Falltrades Falltrades force-pushed the playwright/integration-test-console branch from f60b1ea to 98b40e8 Compare November 27, 2025 14:43
@Falltrades Falltrades mentioned this pull request Nov 27, 2025
Closed
4 tasks
@Falltrades Falltrades force-pushed the playwright/integration-test-console branch 3 times, most recently from 54b0f0e to b4c01ea Compare November 27, 2025 18:30
@Falltrades Falltrades mentioned this pull request Nov 27, 2025
Closed
4 tasks
@Falltrades Falltrades force-pushed the playwright/integration-test-console branch from b4c01ea to 24e84a3 Compare December 1, 2025 15:41
StephaneTrebel
StephaneTrebel requested changes Dec 1, 2025
View reviewed changes
Copy link
Collaborator

@StephaneTrebel StephaneTrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On devrait considérer la création d'un playwright.config.integration.ts qui ciblerait tes tests d'intégration dans un dossier integration-tests qui serait à côté de e2e-tests (et donc avoir deux exécutions de tests playwright dans le package.json)

À rediscuter avec @mathieulaude et @iliesmrf , je pense 😉

@Falltrades Falltrades force-pushed the playwright/integration-test-console branch from 24e84a3 to e294bab Compare December 2, 2025 18:46
@Falltrades Falltrades force-pushed the playwright/integration-test-console branch from e294bab to 92abe0f Compare December 2, 2025 19:01
StephaneTrebel
StephaneTrebel approved these changes Dec 3, 2025
View reviewed changes
Copy link
Collaborator

@StephaneTrebel StephaneTrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM dans l'ensemble 🚀

playwright/playwright.config.ts
/* All timeouts are in milliseconds */
// Timeout for each and every `test` block
timeout: 30_000,
timeout: Number(process.env.CONSOLE_GLOBAL_TIMEOUT) || 30_000,
Copy link
Collaborator

@StephaneTrebel StephaneTrebel Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timeout: Number(process.env.CONSOLE_GLOBAL_TIMEOUT) || 30_000,
timeout: 30_000,

Copy link
Collaborator

@StephaneTrebel StephaneTrebel Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est surtout pour concentrer l'usage des CONSOLE_xxx_TIMEOUT sur leur cible, à savoir les tests d'intégration.
Mais si tu veux garder ça comme ça car on peut en avoir besoin pour les E2E c'est fine by me 😉

Copy link
Contributor Author

@Falltrades Falltrades Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comme t'es ok pour les laisser au cas où, je vais les laisser pour ne pas avoir à relancer toute la pipeline x)

playwright/playwright.config.ts
// Timeout for each and every `expect` command
expect: {
timeout: 10_000,
timeout: Number(process.env.CONSOLE_EXPECT_TIMEOUT) || 10_000,
Copy link
Collaborator

@StephaneTrebel StephaneTrebel Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timeout: Number(process.env.CONSOLE_EXPECT_TIMEOUT) || 10_000,
timeout: 10_000,

@Falltrades Falltrades merged commit 849a93f into main Dec 3, 2025
25 checks passed
@Falltrades Falltrades deleted the playwright/integration-test-console branch December 3, 2025 10:52
@Falltrades Falltrades mentioned this pull request Dec 11, 2025
Closed
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephaneTrebel StephaneTrebel StephaneTrebel approved these changes

@iliesmrf iliesmrf Awaiting requested review from iliesmrf

@mathieulaude mathieulaude Awaiting requested review from mathieulaude

Assignees

@Falltrades Falltrades

Labels

built CI/CD CI/CD stuffs

Projects

None yet

Milestone

Testing - QA

Development

Successfully merging this pull request may close these issues.

3 participants

@Falltrades @StephaneTrebel