Return Options as nullable values over PG Wire #3936
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Improves usability compared to regular DBs.
Before:
After:
Note:
The current implementation returns an empty string (2 bytes:
"") on the wire. A correct one would return actual 0-byteNULLs, but this seemingly requires an elaborate refactoring of the current conversion implementation to support passingOption<AlgebraicValue>straight to the encoder, without converting it to a string first.API and ABI breaking changes
Breaks the PG Wire protocol to move it closer to standard.
Expected complexity level and risk
3:
Will probably have to hear from
pgwire's author if that's correct.Testing