-
Notifications
You must be signed in to change notification settings - Fork 663
Fixes reported issues with the TypeScript SDK #3737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutiertyler
commented
Nov 24, 2025
cloutiertyler
commented
Nov 26, 2025
cloutiertyler
commented
Nov 26, 2025
Contributor
|
Won't this be getting into 1.10.0? |
jsdt
approved these changes
Nov 26, 2025
Collaborator
It's going in, if it's tagged with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes:
SubscriptionHandletype with theREMOTE_MODULEtype applied.camelCasefor column names in code generation.onMyReducercallbacks were passing arguments as variadic params, while the types indicated they would be passed as an object.onMyReducer((ctx, argA, argB, argC) => {})vs onMyReducer((ctx, { argA, argB, argC}) => {})`ScheduleAtbeing used in non-table types.API and ABI breaking changes
Adds a new export, and fixes casing in code genreation.
Expected complexity level and risk
2
Testing
SubscriptionHandleis correctly exportedcamelCaseonMyReducercallbacks now return a single argument