Skip to content

Conversation

@cloutiertyler
Copy link
Contributor

@cloutiertyler cloutiertyler commented Nov 24, 2025

Description of Changes

Fixes:

  • This issue by exporting the SubscriptionHandle type with the REMOTE_MODULE type applied.
  • This issue by converting to camelCase for column names in code generation.
  • Fixes an issue where onMyReducer callbacks were passing arguments as variadic params, while the types indicated they would be passed as an object. onMyReducer((ctx, argA, argB, argC) => {}) vs onMyReducer((ctx, { argA, argB, argC}) => {})`
  • Fixes an issue where the table type name was used instead of the table name in code generation for constructing tables.
  • Fixes issue with ScheduleAt being used in non-table types.
  • Fixes issue where template projects do not use the correct lifecycle reducer setup

API and ABI breaking changes

Adds a new export, and fixes casing in code genreation.

Expected complexity level and risk

2

Testing

  • I have tested that the SubscriptionHandle is correctly exported
  • I have tested that the constraint name is now output in camelCase
  • I have tested that onMyReducer callbacks now return a single argument
  • I have tested that the table name (and view name) is now used instead of the type name for code generation
  • I have tested that the new lifecycle reducers correctly compile

@bfops bfops added release-any To be landed in any release window bugfix Fixes something that was expected to work differently labels Nov 24, 2025
@jdetter jdetter added release-0.10 release-1.10.0 and removed release-any To be landed in any release window release-0.10 labels Nov 25, 2025
@cloutiertyler cloutiertyler mentioned this pull request Nov 25, 2025
2 tasks
@egormanga
Copy link
Contributor

Won't this be getting into 1.10.0?

@jdetter
Copy link
Collaborator

jdetter commented Nov 26, 2025

Won't this be getting into 1.10.0?

It's going in, if it's tagged with release-* then it's going into that release

@cloutiertyler cloutiertyler added this pull request to the merge queue Nov 26, 2025
Merged via the queue into master with commit 1630f0c Nov 26, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes something that was expected to work differently release-1.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants