Adding Abort to C# Websocket #3352
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
reviewed
Oct 3, 2025
jdetter
reviewed
Oct 27, 2025
jdetter
reviewed
Nov 25, 2025
jdetter
approved these changes
Nov 25, 2025
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
I haven't tested this myself but this looks good, just one small nit 👍
Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com> Signed-off-by: rekhoff <r.ekhoff@clockworklabs.io>
Signed-off-by: rekhoff <r.ekhoff@clockworklabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The implementation of a solution to #3044 , this adds an
Abortfunction to theWebSocket, which runs ifDisconnectis called when theWebSocketis not connected.API and ABI breaking changes
Not API breaking.
Expected complexity level and risk
1
Testing
Note: Before change (either on Rust of C# server), server would see 4
Debuglog entries about connecting, but not see theInfolog about the client connection ending like would normally be seen in a disconnect. After change, server shows no log entries at all, because connection is properly aborted.