-
Notifications
You must be signed in to change notification settings - Fork 411
fix(e2e): update package links in astro preset and metro config #7369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: vincent-and-the-doctor
Are you sure you want to change the base?
Conversation
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
0d71671 to
0f15669
Compare
| }); | ||
|
|
||
| test('user is prompted to add email before checkout', async ({ page, context }) => { | ||
| test.only('user is prompted to add email before checkout', async ({ page, context }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| test.only('user is prompted to add email before checkout', async ({ page, context }) => { | |
| test('user is prompted to add email before checkout', async ({ page, context }) => { |
0f15669 to
d725dcc
Compare
d725dcc to
8d0340d
Compare
…mentSetting into Environment resource
991cf03 to
8906507
Compare
The verdaccio step was setting `CLERK_USE_RQ=${{ matrix.clerk-use-rq }}`
which evaluates to an empty string when the matrix variable is undefined.
Since `CLERK_*` is in turbo.json's globalEnv, an empty string creates a
different cache hash than undefined, causing unnecessary rebuilds.
Now CLERK_USE_RQ is only set when explicitly `'true'`, matching the
environment of the build-packages job and allowing cache hits.
wip
Integration tests that create their own applications (using `.clone().commit()`) were failing in CI with "CLERK_FAPI is required" errors. This happened because `setupClerkTestingToken()` needs the CLERK_FAPI environment variable, which is set by calling `clerkSetup()`. Long-running apps automatically call `clerkSetup()` during init, but apps created inline in tests did not. Rather than requiring each test to manually call `clerkSetup()`, moved it into the `Application.dev()` method to run automatically after the server starts. This ensures all applications (both long-running and inline) have proper testing token setup without manual intervention, preventing future test failures and reducing boilerplate.
ae95b94 to
e93998a
Compare
e93998a to
618b772
Compare
618b772 to
4a06520
Compare
7ed8e1f to
2bc1467
Compare
2bc1467 to
917515f
Compare
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change