Skip to content

Commit dc4bbc4

Browse files
nikosdouvlisnikosdouvlis
committed
refactor(turbo): remove redundant build dependencies from integration tests
Integration tests now install packages from Verdaccio with snapshot versions, so they don't need to depend on local builds. Removing these dependencies simplifies the turbo pipeline and allows integration tests to run without waiting for local package builds to complete. Removed dependsOn arrays from all test:integration:* tasks including: - nextjs, nextjs:canary, quickstart - astro, express, ap-flows, generic - localhost, react, remix, tanstack, vue, nuxt, expo Tests will still have access to properly built packages via the snapshot versions published to Verdaccio in the CI pipeline.
1 parent e3ac56c commit dc4bbc4

File tree

2 files changed

+2
-142
lines changed

2 files changed

+2
-142
lines changed

‎.github/workflows/nightly-checks.yml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,9 @@ jobs:
6868
E2E_CLERK_UI_VERSION: "latest"
6969
E2E_NEXTJS_VERSION: "canary"
7070
E2E_NPM_FORCE: "true"
71-
E2E_REACT_DOM_VERSION: "19.1.0"
72-
E2E_REACT_VERSION: "19.1.0"
71+
E2E_REACT_DOM_VERSION: "19.2.1"
72+
E2E_REACT_VERSION: "19.2.1"
7373
INTEGRATION_INSTANCE_KEYS: ${{ secrets.INTEGRATION_INSTANCE_KEYS }}
74-
MAILSAC_API_KEY: ${{ secrets.MAILSAC_API_KEY }}
7574

7675
# Upload test artifacts if tests failed
7776
- name: Upload Test Artifacts

‎turbo.json‎

Lines changed: 0 additions & 139 deletions
Original file line numberDiff line numberDiff line change
@@ -193,240 +193,101 @@
193193
"outputs": []
194194
},
195195
"//#test:integration:ap-flows": {
196-
"dependsOn": [
197-
"@clerk/testing#build",
198-
"@clerk/clerk-js#build",
199-
"@clerk/ui#build",
200-
"@clerk/backend#build",
201-
"@clerk/nextjs#build"
202-
],
203196
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
204197
"inputs": ["integration/**"],
205198
"outputLogs": "new-only"
206199
},
207200
"//#test:integration:generic": {
208-
"dependsOn": [
209-
"@clerk/testing#build",
210-
"@clerk/clerk-js#build",
211-
"@clerk/ui#build",
212-
"@clerk/backend#build",
213-
"@clerk/react#build"
214-
],
215201
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
216202
"inputs": ["integration/**"],
217203
"outputLogs": "new-only"
218204
},
219205
"//#test:integration:express": {
220-
"dependsOn": [
221-
"@clerk/testing#build",
222-
"@clerk/clerk-js#build",
223-
"@clerk/ui#build",
224-
"@clerk/backend#build",
225-
"@clerk/express#build",
226-
"@clerk/react#build"
227-
],
228206
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
229207
"inputs": ["integration/**"],
230208
"outputLogs": "new-only"
231209
},
232210
"//#test:integration:nextjs": {
233-
"dependsOn": [
234-
"@clerk/testing#build",
235-
"@clerk/clerk-js#build",
236-
"@clerk/ui#build",
237-
"@clerk/backend#build",
238-
"@clerk/nextjs#build"
239-
],
240211
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
241212
"inputs": ["integration/**"],
242213
"outputLogs": "new-only"
243214
},
244215
"//#test:integration:nextjs:canary": {
245-
"dependsOn": [
246-
"@clerk/testing#build",
247-
"@clerk/clerk-js#build",
248-
"@clerk/ui#build",
249-
"@clerk/backend#build",
250-
"@clerk/nextjs#build"
251-
],
252216
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
253217
"inputs": ["integration/**"],
254218
"outputLogs": "new-only"
255219
},
256220
"//#test:integration:quickstart": {
257-
"dependsOn": [
258-
"@clerk/testing#build",
259-
"@clerk/clerk-js#build",
260-
"@clerk/ui#build",
261-
"@clerk/backend#build",
262-
"@clerk/nextjs#build"
263-
],
264221
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
265222
"inputs": ["integration/**"],
266223
"outputLogs": "new-only"
267224
},
268225
"//#test:integration:astro": {
269-
"dependsOn": [
270-
"@clerk/testing#build",
271-
"@clerk/clerk-js#build",
272-
"@clerk/ui#build",
273-
"@clerk/backend#build",
274-
"@clerk/astro#build"
275-
],
276226
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
277227
"inputs": ["integration/**"],
278228
"outputLogs": "new-only"
279229
},
280230
"//#test:integration:localhost": {
281-
"dependsOn": [
282-
"@clerk/testing#build",
283-
"@clerk/clerk-js#build",
284-
"@clerk/ui#build",
285-
"@clerk/backend#build",
286-
"@clerk/nextjs#build"
287-
],
288231
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS", "NODE_EXTRA_CA_CERTS"],
289232
"inputs": ["integration/**"],
290233
"outputLogs": "new-only"
291234
},
292235
"//#test:integration:sessions": {
293-
"dependsOn": [
294-
"@clerk/testing#build",
295-
"@clerk/clerk-js#build",
296-
"@clerk/ui#build",
297-
"@clerk/backend#build",
298-
"@clerk/nextjs#build"
299-
],
300236
"env": ["CLEANUP", "DEBUG", "DISABLE_WEB_SECURITY", "E2E_*", "INTEGRATION_INSTANCE_KEYS", "NODE_EXTRA_CA_CERTS"],
301237
"inputs": ["integration/**"],
302238
"outputLogs": "new-only"
303239
},
304240
"//#test:integration:sessions:staging": {
305-
"dependsOn": [
306-
"@clerk/testing#build",
307-
"@clerk/clerk-js#build",
308-
"@clerk/ui#build",
309-
"@clerk/backend#build",
310-
"@clerk/nextjs#build"
311-
],
312241
"env": ["CLEANUP", "DEBUG", "DISABLE_WEB_SECURITY", "E2E_*", "INTEGRATION_INSTANCE_KEYS", "NODE_EXTRA_CA_CERTS"],
313242
"inputs": ["integration/**"],
314243
"outputLogs": "new-only"
315244
},
316245
"//#test:integration:handshake": {
317-
"dependsOn": [
318-
"@clerk/testing#build",
319-
"@clerk/clerk-js#build",
320-
"@clerk/ui#build",
321-
"@clerk/backend#build",
322-
"@clerk/nextjs#build"
323-
],
324246
"env": ["CLEANUP", "DEBUG", "DISABLE_WEB_SECURITY", "E2E_*", "INTEGRATION_INSTANCE_KEYS", "NODE_EXTRA_CA_CERTS"],
325247
"inputs": ["integration/**"],
326248
"outputLogs": "new-only"
327249
},
328250
"//#test:integration:handshake:staging": {
329-
"dependsOn": [
330-
"@clerk/testing#build",
331-
"@clerk/clerk-js#build",
332-
"@clerk/ui#build",
333-
"@clerk/backend#build",
334-
"@clerk/nextjs#build"
335-
],
336251
"env": ["CLEANUP", "DEBUG", "DISABLE_WEB_SECURITY", "E2E_*", "INTEGRATION_INSTANCE_KEYS", "NODE_EXTRA_CA_CERTS"],
337252
"inputs": ["integration/**"],
338253
"outputLogs": "new-only"
339254
},
340255
"//#test:integration:expo-web": {
341-
"dependsOn": [
342-
"@clerk/testing#build",
343-
"@clerk/clerk-js#build",
344-
"@clerk/ui#build",
345-
"@clerk/expo#build",
346-
"@clerk/react#build"
347-
],
348256
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
349257
"inputs": ["integration/**"],
350258
"outputLogs": "new-only"
351259
},
352260
"//#test:integration:tanstack-react-start": {
353-
"dependsOn": [
354-
"@clerk/testing#build",
355-
"@clerk/clerk-js#build",
356-
"@clerk/ui#build",
357-
"@clerk/tanstack-react-start#build",
358-
"@clerk/react#build"
359-
],
360261
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
361262
"inputs": ["integration/**"],
362263
"outputLogs": "new-only"
363264
},
364265
"//#test:integration:vue": {
365-
"dependsOn": ["@clerk/testing#build", "@clerk/clerk-js#build", "@clerk/ui#build", "@clerk/vue#build"],
366266
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
367267
"inputs": ["integration/**"],
368268
"outputLogs": "new-only"
369269
},
370270
"//#test:integration:nuxt": {
371-
"dependsOn": [
372-
"@clerk/testing#build",
373-
"@clerk/clerk-js#build",
374-
"@clerk/ui#build",
375-
"@clerk/vue#build",
376-
"@clerk/backend#build",
377-
"@clerk/nuxt#build"
378-
],
379271
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
380272
"inputs": ["integration/**"],
381273
"outputLogs": "new-only"
382274
},
383275
"//#test:integration:react-router": {
384-
"dependsOn": [
385-
"@clerk/testing#build",
386-
"@clerk/clerk-js#build",
387-
"@clerk/ui#build",
388-
"@clerk/react-router#build",
389-
"@clerk/backend#build",
390-
"@clerk/react#build"
391-
],
392276
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
393277
"inputs": ["integration/**"],
394278
"outputLogs": "new-only"
395279
},
396280
"//#test:integration:billing": {
397-
"dependsOn": [
398-
"@clerk/testing#build",
399-
"@clerk/clerk-js#build",
400-
"@clerk/ui#build",
401-
"@clerk/backend#build",
402-
"@clerk/nextjs#build",
403-
"@clerk/vue#build"
404-
],
405281
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
406282
"inputs": ["integration/**"],
407283
"outputLogs": "new-only"
408284
},
409285
"//#test:integration:machine": {
410-
"dependsOn": [
411-
"@clerk/testing#build",
412-
"@clerk/clerk-js#build",
413-
"@clerk/ui#build",
414-
"@clerk/backend#build",
415-
"@clerk/nextjs#build",
416-
"@clerk/express#build"
417-
],
418286
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
419287
"inputs": ["integration/**"],
420288
"outputLogs": "new-only"
421289
},
422290
"//#test:integration:custom": {
423-
"dependsOn": [
424-
"@clerk/testing#build",
425-
"@clerk/clerk-js#build",
426-
"@clerk/ui#build",
427-
"@clerk/backend#build",
428-
"@clerk/react#build"
429-
],
430291
"env": ["CLEANUP", "DEBUG", "E2E_*", "INTEGRATION_INSTANCE_KEYS"],
431292
"inputs": ["integration/**"],
432293
"outputLogs": "new-only"

0 commit comments

Comments
 (0)