feat(ci): use snapshot versions in verdaccio for integration tests

nikosdouvlis · nikosdouvlis · commit e3ac56c40800 · 2025-12-07T23:55:09.000+02:00
Integration tests were failing because packages published to Verdaccio with the 'integration' dist-tag had transitive dependencies (e.g. @clerk/shared from @clerk/ui) that were resolved from npm instead of the local Verdaccio registry. Changed approach to use snapshot versions that don't exist on npm: - Create unique snapshot versions with `changeset version --snapshot ci` - Publish to 'latest' tag instead of 'integration' tag - Updated linkPackage to return '*' in CI (gets latest snapshot) - Modified snapshot.mjs to always generate changeset for all packages - Updated verdaccio action to check for snapshot versions instead of integration tag - Removed redundant long-running apps from presets that were causing test duplication This ensures all @clerk packages, including transitive dependencies, are installed from the locally published Verdaccio versions.
diff --git a/.github/actions/verdaccio/action.yml b/.github/actions/verdaccio/action.yml
@@ -75,7 +75,7 @@ runs:
     - name: Print published Clerk package versions
       shell: bash
       run: |
-        echo "Published @clerk packages under 'integration' tag:"
+        echo "Published @clerk packages (snapshot versions):"
         echo "=================================================="
         packages=(
           "@clerk/agent-toolkit"
@@ -102,6 +102,6 @@ runs:
           "@clerk/vue"
         )
         for pkg in "${packages[@]}"; do
-          version=$(pnpm view "$pkg@integration" version 2>/dev/null || echo "not found")
-          printf "%-35s %s\n" "$pkg@integration:" "$version"
+          version=$(pnpm view "$pkg" version 2>/dev/null || echo "not found")
+          printf "%-35s %s\n" "$pkg:" "$version"
         done
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -64,10 +64,10 @@ jobs:
       - name: Setup
         id: config
         uses: ./.github/actions/init-blacksmith
-        with:
-          turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
-          turbo-team: ${{ vars.TURBO_TEAM }}
-          turbo-token: ${{ secrets.TURBO_TOKEN }}
+        # with:
+        # turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
+        # turbo-team: ${{ vars.TURBO_TEAM }}
+        # turbo-token: ${{ secrets.TURBO_TOKEN }}
 
       - name: Verify lockfile is deduped
         run: pnpm dedupe --check
@@ -110,11 +110,11 @@ jobs:
       - name: Setup
         id: config
         uses: ./.github/actions/init-blacksmith
-        with:
-          turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
-          turbo-summarize: ${{ env.TURBO_SUMMARIZE }}
-          turbo-team: ${{ vars.TURBO_TEAM }}
-          turbo-token: ${{ secrets.TURBO_TOKEN }}
+        # with:
+        # turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
+        # turbo-summarize: ${{ env.TURBO_SUMMARIZE }}
+        # turbo-team: ${{ vars.TURBO_TEAM }}
+        # turbo-token: ${{ secrets.TURBO_TOKEN }}
 
       - name: Turbo Build
         run: pnpm turbo build $TURBO_ARGS --only
@@ -154,11 +154,11 @@ jobs:
       - name: Setup
         id: config
         uses: ./.github/actions/init-blacksmith
-        with:
-          turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
-          turbo-summarize: ${{ env.TURBO_SUMMARIZE }}
-          turbo-team: ${{ vars.TURBO_TEAM }}
-          turbo-token: ${{ secrets.TURBO_TOKEN }}
+        # with:
+        # turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
+        # turbo-summarize: ${{ env.TURBO_SUMMARIZE }}
+        # turbo-team: ${{ vars.TURBO_TEAM }}
+        # turbo-token: ${{ secrets.TURBO_TOKEN }}
 
       - name: Check size using bundlewatch
         continue-on-error: true
@@ -231,10 +231,10 @@ jobs:
         with:
           # Ensures that all builds are cached appropriately with a consistent run name `Unit Tests (20)`.
           node-version: ${{ matrix.node-version }}
-          turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
-          turbo-summarize: ${{ env.TURBO_SUMMARIZE }}
-          turbo-team: ${{ vars.TURBO_TEAM }}
-          turbo-token: ${{ secrets.TURBO_TOKEN }}
+          # turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
+          # turbo-summarize: ${{ env.TURBO_SUMMARIZE }}
+          # turbo-team: ${{ vars.TURBO_TEAM }}
+          # turbo-token: ${{ secrets.TURBO_TOKEN }}
 
       - name: Rebuild @clerk/shared with CLERK_USE_RQ=true
         if: ${{ matrix.clerk-use-rq == 'true' }}
@@ -280,7 +280,8 @@ jobs:
           retention-days: 5
 
   integration-tests:
-    needs: [check-permissions, build-packages]
+    # needs: [check-permissions, build-packages]
+    needs: [check-permissions]
     if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
     name: Integration Tests (${{ matrix.test-name }}, ${{ matrix.test-project }}${{ matrix.next-version && format(', {0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
     permissions:
@@ -355,9 +356,9 @@ jobs:
         id: config
         uses: ./.github/actions/init-blacksmith
         with:
-          turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
-          turbo-team: ${{ vars.TURBO_TEAM }}
-          turbo-token: ${{ secrets.TURBO_TOKEN }}
+          # turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
+          # turbo-team: ${{ vars.TURBO_TEAM }}
+          # turbo-token: ${{ secrets.TURBO_TOKEN }}
           playwright-enabled: true
 
       - name: Verify jq is installed
@@ -405,12 +406,16 @@ jobs:
         env:
           CLERK_USE_RQ: true
 
+      - name: Version packages for snapshot
+        if: ${{ steps.task-status.outputs.affected == '1' }}
+        run: npm run version-packages:snapshot ci
+
       - name: Verdaccio
         if: ${{ steps.task-status.outputs.affected == '1' }}
         uses: ./.github/actions/verdaccio
         with:
           publish-cmd: |
-            if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else CLERK_USE_RQ=${{ matrix.clerk-use-rq }} pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag --tag integration; fi
+            if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else ${{ matrix.clerk-use-rq == 'true' && 'CLERK_USE_RQ=true' || '' }} pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag --tag latest; fi
 
       - name: Edit .npmrc [link-workspace-packages=false]
         run: sed -i -E 's/link-workspace-packages=(deep|true)/link-workspace-packages=false/' .npmrc
@@ -423,6 +428,8 @@ jobs:
           pnpm config set minimum-release-age-exclude @clerk/*
           pnpm add @clerk/backend
 
+      # Install published packages from Verdaccio to test against real npm install scenarios
+      # rather than local monorepo builds. Validates package structure, dependencies, and entry points.
       - name: Install @clerk/clerk-js in os temp
         if: ${{ steps.task-status.outputs.affected == '1' }}
         working-directory: ${{runner.temp}}
@@ -483,7 +490,6 @@ jobs:
           E2E_CLERK_ENCRYPTION_KEY: ${{ matrix.clerk-encryption-key }}
           CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}
           INTEGRATION_INSTANCE_KEYS: ${{ secrets.INTEGRATION_INSTANCE_KEYS }}
-          MAILSAC_API_KEY: ${{ secrets.MAILSAC_API_KEY }}
           NODE_EXTRA_CA_CERTS: ${{ github.workspace }}/integration/certs/rootCA.pem
 
       - name: Upload test-results
@@ -518,10 +524,10 @@ jobs:
         with:
           turbo-enabled: true
           node-version: 22
-          turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
-          turbo-summarize: ${{ env.TURBO_SUMMARIZE }}
-          turbo-team: ${{ vars.TURBO_TEAM }}
-          turbo-token: ${{ secrets.TURBO_TOKEN }}
+          # turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
+          # turbo-summarize: ${{ env.TURBO_SUMMARIZE }}
+          # turbo-team: ${{ vars.TURBO_TEAM }}
+          # turbo-token: ${{ secrets.TURBO_TOKEN }}
 
       - name: Publish with pkg-pr-new
         run: pnpm run build && pnpx pkg-pr-new@${{ vars.PKG_PR_NEW_VERSION || '0.0.49' }} publish --compact --pnpm './packages/*'
diff --git a/integration/presets/longRunningApps.ts b/integration/presets/longRunningApps.ts
@@ -42,15 +42,7 @@ export const createLongRunningApps = () => {
      * Billing apps
      */
     { id: 'withBillingJwtV2.next.appRouter', config: next.appRouter, env: envs.withBillingJwtV2 },
-    { id: 'withBilling.next.appRouter', config: next.appRouter, env: envs.withBilling },
     { id: 'withBillingJwtV2.vue.vite', config: vue.vite, env: envs.withBillingJwtV2 },
-    { id: 'withBilling.vue.vite', config: vue.vite, env: envs.withBilling },
-
-    /**
-     * Machine auth apps
-     */
-    { id: 'withMachine.express.vite', config: express.vite, env: envs.withAPIKeys },
-    { id: 'withMachine.next.appRouter', config: next.appRouter, env: envs.withAPIKeys },
 
     /**
      * Vite apps - basic flows
@@ -68,7 +60,6 @@ export const createLongRunningApps = () => {
     /**
      * Various apps - basic flows
      */
-    { id: 'withBilling.astro.node', config: astro.node, env: envs.withBilling },
     { id: 'astro.node.withCustomRoles', config: astro.node, env: envs.withCustomRoles },
     { id: 'astro.static.withCustomRoles', config: astro.static, env: envs.withCustomRoles },
     { id: 'expo.expo-web', config: expo.expoWeb, env: envs.withEmailCodes },
diff --git a/integration/presets/utils.ts b/integration/presets/utils.ts
@@ -3,7 +3,9 @@ import path from 'node:path';
 export function linkPackage(pkg: string, tag?: string) {
   // eslint-disable-next-line turbo/no-undeclared-env-vars
   if (process.env.CI === 'true') {
-    return tag || '*';
+    // In CI, use '*' to get the latest version from Verdaccio
+    // which will be the snapshot version we just published
+    return '*';
   }
 
   return `link:${path.resolve(process.cwd(), `packages/${pkg}`)}`;
diff --git a/scripts/snapshot.mjs b/scripts/snapshot.mjs
@@ -25,13 +25,14 @@ try {
   // this will remove the prerelease versions
   // but will also clear the changeset .md files
   await $`pnpm changeset version`;
-  // generate a temp .md file that indicates that all packages have changes
-  // in order to force a snapshot release
-  await $`touch .changeset/snap.md && echo ${snapshot} > .changeset/snap.md`;
 } catch {
-  // otherwise, do nothing
+  // not in pre-release mode, continue
 }
 
+// Always generate a temp .md file that indicates that all packages have changes
+// in order to force a snapshot release of all packages
+await $`touch .changeset/snap.md && echo ${snapshot} > .changeset/snap.md`;
+
 const res = await $`pnpm changeset version --snapshot ${prefix}`;
 const success = !res.stderr.includes('No unreleased changesets found');
 
